Skip to content

Handle InstanceOfflinePing and close related clients #612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Jul 30, 2019
Merged

Handle InstanceOfflinePing and close related clients #612

merged 13 commits into from
Jul 30, 2019

Conversation

JialinXin
Copy link
Contributor

@JialinXin JialinXin commented Jul 23, 2019 •
edited
Loading

  1. Store client-instance mapping from OpenConnectionMessages
  2. Handle offline ping message to disconnect clients on crashes service instances

Fix #416, #539

vicancy
vicancy reviewed Jul 24, 2019
View reviewed changes
@JialinXin JialinXin merged commit 36abd7a into Azure:dev Jul 30, 2019
@vicancy vicancy mentioned this pull request Aug 13, 2019
Merged
@JialinXin JialinXin deleted the instanceNotification branch December 26, 2019 03:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vicancy vicancy vicancy approved these changes

@vwxyzh vwxyzh Awaiting requested review from vwxyzh

@zackliu zackliu Awaiting requested review from zackliu

@wanlwanl wanlwanl Awaiting requested review from wanlwanl

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SDK cannot detect some clients dropped when ASRS instance crashed.
2 participants
@JialinXin @vicancy