Change endpoint online to push mode #570
Conversation
src/Microsoft.Azure.SignalR.Common/EndpointRouters/DefaultMessageRouter.cs
Outdated
Show resolved
Hide resolved
| } | ||
|
|
||
| public Task StartAsync(string target = null) | ||
| { | ||
| ConnectionStatusChanged?.Invoke(new StatusChange(ServiceConnectionStatus.Inited, Status)); |
There was a problem hiding this comment.
Inited [](start = 85, length = 6)
why added an "Inited" status but only used in test? not Connecting?
There was a problem hiding this comment.
inited status is added for ServiceConnectionContainer to have an initial state Inited instead of Disconnected as the initial state, so that ServiceConnectionContainer can get notified when the inner server connections has status changed to Disconnected. And I am not able to reuse Connecting as for backward compatibility, the status of ServiceConnectionContainer should be considered as online until it starts the inner service connection.
There was a problem hiding this comment.
So with inited we explicitly defined a stage for the server connection between it is created to it is connected. I think it is clear, as for now, we consider the endpoint as online in this stage, which is when the app server starts. And later, we can easily change the endpoint status for this stage if there is a requirement.
No description provided.