Add maxPageSize to GroupMemberQueryMessage
#2193
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This pull request adds a new optional property, MaxPageSize, to the GroupMemberQueryMessage and updates its serialization, deserialization, equality checking, and test coverage.
- Added MaxPageSize to the GroupMemberQueryMessage model with updated XML documentation.
- Updated serialization/deserialization routines in ServiceProtocol.cs to handle the new property.
- Updated tests in ServiceProtocolFacts.cs and the equality comparer in ServiceMessageEqualityComparer.cs to verify the new field.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| test/Microsoft.Azure.SignalR.Protocols.Tests/ServiceProtocolFacts.cs | Added new test data entries to validate the updated binary format with MaxPageSize. |
| test/Microsoft.Azure.SignalR.Protocols.Tests/ServiceMessageEqualityComparer.cs | Included MaxPageSize in equality checks. |
| src/Microsoft.Azure.SignalR.Protocols/ServiceProtocol.cs | Updated serialization and deserialization logic for GroupMemberQueryMessage to include MaxPageSize. |
| src/Microsoft.Azure.SignalR.Protocols/ServiceMessage.cs | Added the MaxPageSize property with XML comments. |
test/Microsoft.Azure.SignalR.Protocols.Tests/ServiceProtocolFacts.cs
Outdated
Show resolved
Hide resolved
…cts.cs Co-authored-by: Copilot <[email protected]>
vwxyzh
previously approved these changes
Apr 29, 2025
|
please fix compile error. |
vwxyzh
approved these changes
Apr 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.