Enable stream and add cli for streaming. #2178
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Y-Sindo
reviewed
Mar 19, 2025
Y-Sindo
reviewed
Mar 20, 2025
Y-Sindo
reviewed
Mar 20, 2025
vicancy
reviewed
May 19, 2025
src/Microsoft.Azure.SignalR.Management/HubContext/StreamingManagerAdapter.cs
Outdated
Show resolved
Hide resolved
vicancy
previously approved these changes
May 19, 2025
vicancy
approved these changes
May 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several changes to the Azure SignalR project, primarily focusing on adding a new CLI sample project, updating the streaming manager interface, and improving error logging. Below are the most important changes:
New CLI Sample Project:
ChatSample.Clito the solution fileAzureSignalR.sln. This includes project references and solution configurations. [1] [2] [3]ChatSample.Cli.csprojwith necessary configurations and package references.Streaming Manager Interface Updates:
IStreamingManagerinterface from internal to public, allowing it to be accessed outside the assembly.StreamingManagerclass and its adapter to be public, and added logger dependency for improved error handling. [1] [2] [3]Service Hub Context Enhancements:
Streamingproperty toIServiceHubContextand its implementations, providing access to the streaming manager. [1] [2] [3]Minor Changes:
JsonPayloadMessageContentto simplify the content type declaration.These changes improve the functionality and maintainability of the Azure SignalR project by adding new features and enhancing existing ones.