Skip to content

Remove authorization for healthcheck API #2105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 5, 2024
Merged

Remove authorization for healthcheck API #2105

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
251e71b
remove authorization for healthcheck
cqnguy23 Dec 3, 2024
3577868
use allow anonymous instead
cqnguy23 Dec 5, 2024
74ee758
Merge branch 'dev' into remove-authorization-for-healthcheck
cqnguy23 Dec 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/Microsoft.Azure.SignalR.Emulator/Common/SignalRServiceWebApiDefinition.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ internal abstract class SignalRServiceWebApiDefinition : ControllerBase
/// <response code="200">The service is healthy</response>
[HttpGet("health"), HttpHead("health")]
[ProducesResponseType(200)]
[AllowAnonymous]
public abstract IActionResult GetHealthStatus();

// POST /api/v1/hubs/chat
Expand Down
9 changes: 9 additions & 0 deletions test/Microsoft.Azure.SignalR.Emulator.Tests/Controllers/SignalRServiceEmulatorWebApiTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,15 @@ public SignalRServiceEmulatorWebApiTests()
_controller.ControllerContext = controllerContext;
}

[Fact]
public void HealthCheckReturnsOK()
{
var result = _controller.GetHealthStatus();

// assert
Assert.IsType<OkResult>(result);
}

// CheckConnectionExistence Tests
[Fact]
public void CheckConnectionExistenceValidConnectionReturnsOk()
Expand Down
Loading