Rewrite culture handling logic #2068
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xingsy97
force-pushed
the
refactor-culture-main
branch
from
d0e4d1d to
7b20491
Compare
vicancy
reviewed
Nov 8, 2024
src/Microsoft.Azure.SignalR.AspNet/Middleware/NegotiateMiddleware.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Azure.SignalR/ServerConnections/ServiceConnection.cs
Outdated
Show resolved
Hide resolved
xingsy97
force-pushed
the
refactor-culture-main
branch
3 times, most recently
from
7972e63 to
2152f07
Compare
vicancy
reviewed
Nov 13, 2024
src/Microsoft.Azure.SignalR.Common/Interfaces/IClientConnectionManager.cs
Outdated
Show resolved
Hide resolved
xingsy97
force-pushed
the
refactor-culture-main
branch
from
8fd466e to
47b8960
Compare
xingsy97
changed the title
xingsy97
force-pushed
the
refactor-culture-main
branch
2 times, most recently
from
3f24099 to
aaad24b
Compare
Contributor
|
Add some UTs? |
vicancy
reviewed
Nov 22, 2024
src/Microsoft.Azure.SignalR.Common/DefaultCultureFeatureManager.cs
Outdated
Show resolved
Hide resolved
xingsy97
force-pushed
the
refactor-culture-main
branch
from
aaad24b to
879e4a2
Compare
xingsy97
force-pushed
the
refactor-culture-main
branch
2 times, most recently
from
06f6a82 to
03acfc8
Compare
xingsy97
force-pushed
the
refactor-culture-main
branch
from
03acfc8 to
5c1f339
Compare
vicancy
reviewed
Jan 22, 2025
vicancy
approved these changes
Feb 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #2067
Fix #2038