Throw http response content when 403 #2046
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
terencefan
force-pushed
the
tefa/add-403-nginx-exceptions
branch
from
c540d88 to
44baf29
Compare
terencefan
force-pushed
the
tefa/add-403-nginx-exceptions
branch
5 times, most recently
from
ff2c6c6 to
fff5544
Compare
terencefan
force-pushed
the
tefa/add-403-nginx-exceptions
branch
3 times, most recently
from
24e7e78 to
954851b
Compare
vicancy
reviewed
Oct 25, 2024
src/Microsoft.Azure.SignalR.Common/Exceptions/AzureSignalRForbiddenException.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Azure.SignalR.Common/Auth/MicrosoftEntra/MicrosoftEntraAccessKey.cs
Show resolved
Hide resolved
terencefan
force-pushed
the
tefa/add-403-nginx-exceptions
branch
2 times, most recently
from
4af3ec3 to
79cda63
Compare
terencefan
changed the title
terencefan
force-pushed
the
tefa/add-403-nginx-exceptions
branch
from
d69320d to
dd3258c
Compare
vicancy
reviewed
Oct 28, 2024
src/Microsoft.Azure.SignalR.Common/Exceptions/AzureSignalRForbiddenException.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Azure.SignalR.Common/Exceptions/AzureSignalRAccessTokenNotAuthorizedException.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Azure.SignalR.Common/Exceptions/AzureSignalRRuntimeException.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Azure.SignalR.Common/Exceptions/AzureSignalRUnauthorizedException.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Azure.SignalR.Common/Exceptions/AzureSignalRRuntimeException.cs
Outdated
Show resolved
Hide resolved
terencefan
force-pushed
the
tefa/add-403-nginx-exceptions
branch
2 times, most recently
from
c72d529 to
5e4bf93
Compare
terencefan
changed the title
vicancy
reviewed
Oct 28, 2024
src/Microsoft.Azure.SignalR.Common/Exceptions/AzureSignalRAccessTokenNotAuthorizedException.cs
Show resolved
Hide resolved
src/Microsoft.Azure.SignalR.Common/Exceptions/AzureSignalRAccessTokenNotAuthorizedException.cs
Show resolved
Hide resolved
src/Microsoft.Azure.SignalR.Common/Exceptions/AzureSignalRRuntimeException.cs
Outdated
Show resolved
Hide resolved
terencefan
force-pushed
the
tefa/add-403-nginx-exceptions
branch
2 times, most recently
from
49c6644 to
edf4cbc
Compare
terencefan
force-pushed
the
tefa/add-403-nginx-exceptions
branch
from
edf4cbc to
9be8320
Compare
vicancy
approved these changes
Oct 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Throw http response content when 403