Skip to content

Add more system claims and 'sub' support #1916

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 21, 2024
Merged

Add more system claims and 'sub' support #1916

merged 1 commit into from
Feb 21, 2024

Conversation

vicancy
Copy link
Member

@vicancy vicancy commented Feb 21, 2024

Fix #1911 by:

  1. Consider all string type system claims as user claims, rename and reconstruct in the SDK to avoid breaking changes to the customers
  2. Special handling for "sub" claim, since "sub" claim is also used by SignalR as the UserId of the connection. Keep the first "sub" as it is, and rename other "sub" (if any) to user claims.

@vicancy vicancy merged commit fb60e1c into Azure:dev Feb 21, 2024
@vicancy vicancy deleted the cl branch February 21, 2024 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vwxyzh vwxyzh vwxyzh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Breaking Change][Upcoming] Add strong type validation for JWT registered claims
2 participants
@vicancy @vwxyzh