Fix RemoveConnectionFromAllGroups #1721
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Y-Sindo
reviewed
Nov 14, 2022
|
|
||
| public abstract Task RemoveFromGroupAsync(string connectionId, string groupName, CancellationToken cancellationToken = default); | ||
|
|
||
| public abstract Task RemoveFromAllGroupsAsync(string connectionId, CancellationToken cancellationToken); |
Member
There was a problem hiding this comment.
Suggested change
| public abstract Task RemoveFromAllGroupsAsync(string connectionId, CancellationToken cancellationToken); | |
| public abstract Task RemoveFromAllGroupsAsync(string connectionId, CancellationToken cancellationToken = default); |
| private readonly IHubLifetimeManager _lifetimeManager; | ||
|
|
||
| public GroupManagerAdapter(IGroupManager groupManager) | ||
| public GroupManagerAdapter(IGroupManager groupManager, IHubLifetimeManager lifetimeManager) |
Member
There was a problem hiding this comment.
Remove IGroupManager and implements all the methods with IHubLifetimeManager?
Y-Sindo
reviewed
Nov 14, 2022
| { | ||
| if (IsInvalidArgument(connectionId)) | ||
| { | ||
| throw new ArgumentException(NullOrEmptyStringErrorMessage, nameof(connectionId)); |
Member
There was a problem hiding this comment.
This method can be deleted. It overrides the base class but exactly does the same thing.
Y-Sindo
approved these changes
Nov 14, 2022
terencefan
pushed a commit
to terencefan/azure-signalr
that referenced
this pull request
May 5, 2023
* Decouple RemoveConnectionFromAllGroups from RemoveConnectionFromGroup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the changes
RemoveConnectionFromAllGroupsfromRemoveConnectionFromGroup...FromAllGroupswas implemented by calling...FromGroupwithgroup=null