Fix HubConnectionContext.UserIdentifier is null when negotiation with Management SDK
#1691
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Y-Sindo
force-pushed
the
userName
branch
2 times, most recently
from
5d7cc4d to
b41b6b5
Compare
vicancy
reviewed
Sep 28, 2022
When clients negotiatie with Management SDK and connect to SignalR server, IUserIdProvider might not work as the user ID is set directly in the Management SDK.
To make HubConnectionContext.UserIdentifier have the valid value in this case, we should set it before the server accesses it. HubLifetimeManager{THub}.OnConnectedAsync(HubConnectionContext) is the only chance we can set the value. However, we cannot access the Constants.ClaimType.UserId as ASRS system claims are trimmed there. HubConnectionContext.Features is the place where we can store the user Id.
The following code is the injection point.
https://github.com/dotnet/aspnetcore/blob/v6.0.9/src/SignalR/server/Core/src/HubConnectionHandler.cs#L132-L141
Fixes Azure#1679
vicancy
approved these changes
Sep 28, 2022
JialinXin
added a commit
that referenced
this pull request
Nov 8, 2022
* Update Actions to use dotnet build (#1663) * Update windows.yml * Add configurable options (#1654) * Update CI to enable net7.0 preview builds (#1677) * Support net7.0 * update osx/ubuntu. * revert common package upgrade. * update build-source guide and revert net7.0 in src. * Add OrTimeout() * Fix build warnings and add net6 samples (#1676) * Fix build warning * Update docs * Fix build failure * Fix test failure * Fix vlunerability issue (#1678) * Fix vlunerability issue * fix filters * fix filters * Update use-signalr-service.md (#1683) * Change emulator to net6.0 (#1682) * Change emulator to net6.0 * Fix test * Add filter property...... (#1686) * Add filter * Add multiPayload case * Adding comments * Update management-sdk-guide.md (#1689) Improve a confusing statement. The original statement can also be interpreted as this SDK only supports SignalR clients based on ASP.NET Core C#, which confuses users. #1688 * Expose InstanceId in ClientConnectionContext (#1692) * Fix `HubConnectionContext.UserIdentifier` is null when negotiation with Management SDK (#1691) When clients negotiatie with Management SDK and connect to SignalR server, IUserIdProvider might not work as the user ID is set directly in the Management SDK. To make HubConnectionContext.UserIdentifier have the valid value in this case, we should set it before the server accesses it. HubLifetimeManager{THub}.OnConnectedAsync(HubConnectionContext) is the only chance we can set the value. However, we cannot access the Constants.ClaimType.UserId as ASRS system claims are trimmed there. HubConnectionContext.Features is the place where we can store the user Id. The following code is the injection point. https://github.com/dotnet/aspnetcore/blob/v6.0.9/src/SignalR/server/Core/src/HubConnectionHandler.cs#L132-L141 Fixes #1679 * Add ClientInvocationManager (#1684) * add ClientInvocationManager * update CallerClientResultsManager (#1697) add `TryCompleteResult` for `ErrorCompletionMessage` * Implement close on client authentication expiration (#1699) * Add spec for client-invocation. (#1701) * Add spec for client-invocation. * minor update direction for ErrorCompletionMessage * Add client Invocation implementation and UTs (#1687) * Add client Invocation implementation and UTs * [ClientInvocation] Fix cleanup in caller case. (#1702) * Fix cleanup in caller case. * fix UT. * Update src/Microsoft.Azure.SignalR.Common/ClientInvocation/IClientInvocationManager.cs Co-authored-by: Liangying.Wei <[email protected]> Co-authored-by: Liangying.Wei <[email protected]> * Add ClientResultSample (#1703) * Add ClientResultSample * Move file * minor update. * minor update README. * show server/service ex.message * Add Broadcast method and update README * Fix proxy not applied to serverless transient mode (#1708) Fix #1700 * silent IDE0090 check (#1709) * reduce retry interval when auth failed (#1451) * Clean up dependencies. (#1711) * Update dep to GA version. * clean up dependencies * clean management. * fix test dep. Co-authored-by: Liangying.Wei <[email protected]> Co-authored-by: Kevin Guo <[email protected]> Co-authored-by: yzt <[email protected]> Co-authored-by: Eric Xing <[email protected]> Co-authored-by: Terence Fan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When clients negotiatie with Management SDK and connect to SignalR server, IUserIdProvider might not work as the user ID is set directly in the Management SDK.
To make HubConnectionContext.UserIdentifier have the valid value in this case, we should set it before the server accesses it. HubLifetimeManager{THub}.OnConnectedAsync(HubConnectionContext) is the only chance we can set the value. However, we cannot access the Constants.ClaimType.UserId as ASRS system claims are trimmed there. HubConnectionContext.Features is the place where we can store the user Id.
The following code is the injection point.
https://github.com/dotnet/aspnetcore/blob/v6.0.9/src/SignalR/server/Core/src/HubConnectionHandler.cs#L132-L141
Fixes #1679