Skip to content
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
55 commits
Select commit Hold shift + click to select a range
a3451e6
add ClientResultsManager
xingsy97 Sep 20, 2022
a33c904
add ClientResultsManager
xingsy97 Sep 20, 2022
b08557f
Merge branch 'dev' into ci-ClientResultsManager
xingsy97 Sep 20, 2022
96058f5
re-design ClientResultsManager
xingsy97 Sep 23, 2022
00348d6
Merge branch 'ci-ClientResultsManager' of https://github.com/xingsy97…
xingsy97 Sep 23, 2022
a03f434
Merge branch 'dev' into ci-ClientResultsManager
xingsy97 Sep 23, 2022
79a0567
main logic for client invocation
xingsy97 Sep 23, 2022
28dc3c6
typo fix
xingsy97 Sep 23, 2022
6b504cf
Merge branch 'ci-ClientResultsManager' of https://github.com/xingsy97…
xingsy97 Sep 23, 2022
f3281af
add ClientInvocation main logic
xingsy97 Sep 23, 2022
790b6c0
bug fix
xingsy97 Sep 23, 2022
f594136
bug fix
xingsy97 Sep 23, 2022
9dccae7
bug fix
xingsy97 Sep 23, 2022
a7c8c8a
update
xingsy97 Sep 23, 2022
517dfaa
update
xingsy97 Sep 23, 2022
cfd493b
update interface, add simple unit tests
xingsy97 Sep 23, 2022
f1b96c1
update
xingsy97 Sep 23, 2022
7a13169
update
xingsy97 Sep 25, 2022
b129204
update
xingsy97 Sep 26, 2022
67c9783
sync interface
xingsy97 Sep 26, 2022
acc313a
update
xingsy97 Sep 26, 2022
6cad3ee
update
xingsy97 Sep 26, 2022
c73d59c
rename, relocation and other updates
xingsy97 Sep 26, 2022
46f1b4c
update RoutedClientResultsManager
xingsy97 Sep 26, 2022
ea7b1bb
update
xingsy97 Sep 26, 2022
f4e143c
sync with PR 1684 and some updates
xingsy97 Sep 27, 2022
ee60530
minor fix
xingsy97 Sep 27, 2022
d2a3178
update about nameProvider
xingsy97 Sep 27, 2022
5cd56c4
update
xingsy97 Sep 27, 2022
0e71e48
Merge branch 'dev' into ci-ClientResultsManager
xingsy97 Sep 27, 2022
2137268
Merge branch 'dev' into ci-ClientResultsManager
xingsy97 Sep 28, 2022
8299c2d
Merge branch 'dev' into ci-main
xingsy97 Sep 28, 2022
d18743a
tmp
xingsy97 Sep 28, 2022
1eec339
add `type` in `AddInvocation` and other updates
xingsy97 Sep 28, 2022
d522182
use RawResult for routed client invocation return type
xingsy97 Sep 29, 2022
557de85
Merge branch 'dev' into ci-ClientResultsManager
xingsy97 Sep 29, 2022
ecf28b4
update
xingsy97 Oct 10, 2022
789427d
Merge branch 'dev' into ci-main
xingsy97 Oct 10, 2022
b7d027e
update
xingsy97 Oct 10, 2022
d48ad23
Merge branch 'ci-ClientResultsManager' of https://github.com/xingsy97…
xingsy97 Oct 10, 2022
55b5fb4
add `BaseClientResultsManager` and `RemoveServiceMappingMessage`
xingsy97 Oct 11, 2022
8811ca0
remove independent mapping information dictionary
xingsy97 Oct 12, 2022
7867dd8
undo comment of ClientCompletionMessage
xingsy97 Oct 12, 2022
c4f7ad7
update
xingsy97 Oct 12, 2022
46eaf5a
update exception
xingsy97 Oct 13, 2022
c5aca5a
update
xingsy97 Oct 13, 2022
80031be
update
xingsy97 Oct 13, 2022
4d196f0
update
xingsy97 Oct 13, 2022
7f5d42e
update
xingsy97 Oct 13, 2022
e296cb8
hubProtocolResolver null check
xingsy97 Oct 13, 2022
15876d6
format fix
xingsy97 Oct 13, 2022
4fc63e5
Merge branch 'ci-main' into ci-ClientResultsManager
xingsy97 Oct 13, 2022
f4e9f8f
Revert bad merge "Merge branch 'ci-main' into ci-ClientResultsManager"
xingsy97 Oct 13, 2022
b97589f
route server won't record RouterInstanceId
xingsy97 Oct 14, 2022
8ec3042
fix bug for `TrySetCanceled`
xingsy97 Oct 14, 2022
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -1,14 +1,15 @@
// Copyright (c) Microsoft. All rights reserved.
// Licensed under the MIT license. See LICENSE file in the project root for full license information.

using System;
using Microsoft.AspNetCore.SignalR;

namespace Microsoft.Azure.SignalR
{
internal sealed class DummyClientInvocationManager : IClientInvocationManager
{
public ICallerClientResultsManager Caller { get; }
public IRoutedClientResultsManager Router { get; }
public ICallerClientResultsManager Caller => throw new NotSupportedException();
public IRoutedClientResultsManager Router => throw new NotSupportedException();

public DummyClientInvocationManager()
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -185,30 +185,11 @@ public bool TryGetInvocationReturnType(string invocationId, out Type type)

// Unused, here to honor the IInvocationBinder interface but should never be called
public Type GetStreamItemType(string streamId) => throw new NotImplementedException();
}

class PendingInvocation {
public PendingInvocation(Type type, string connectionId, string routerInstanceId, object tcs, Action<object, CompletionMessage> complete)
private record PendingInvocation(Type Type, string ConnectionId, string RouterInstanceId, object Tcs, Action<object, CompletionMessage> Complete)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove string RouterInstanceId from ctor

{
this.Type = type;
this.ConnectionId = connectionId;
this.RouterInstanceId = routerInstanceId;
this.Tcs = tcs;
this.Complete = complete;
public string RouterInstanceId { get; set; } = RouterInstanceId;
}

public Type Type { get; set; }

public string ConnectionId { get; set; }

public string InstanceId { get; set; }

public string RouterInstanceId { get; set; }

public object Tcs { get; set; }

public Action<object, CompletionMessage> Complete { get; set; }

}
}
#endif
Original file line number Diff line number Diff line change
Expand Up @@ -101,22 +101,11 @@ public bool TryGetInvocationReturnType(string invocationId, out Type type)
type = null;
return false;
}
}

class RoutedInvocation
{
public RoutedInvocation(string connectionId, string callerServerId, string routerInstanceId)
private record RoutedInvocation(string ConnectionId, string CallerServerId, string RouterInstanceId)
{
this.ConnectionId = connectionId;
this.CallerServerId = callerServerId;
this.RouterInstanceId = routerInstanceId;
public string RouterInstanceId { get; set; } = RouterInstanceId;
}

public string ConnectionId { get; set; }

public string CallerServerId { get; set; }

public string RouterInstanceId { get; set; }
}
}
#endif