Add type=azure for connection string. #1616
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
terencefan
force-pushed
the
aad-access-key
branch
from
23aa842 to
976799d
Compare
vicancy
reviewed
May 20, 2022
src/Microsoft.Azure.SignalR.Common/Utilities/ConnectionStringParser.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Azure.SignalR.Common/Utilities/ConnectionStringParser.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Azure.SignalR.Common/Utilities/ConnectionStringParser.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Azure.SignalR.Common/Utilities/ConnectionStringParser.cs
Outdated
Show resolved
Hide resolved
terencefan
force-pushed
the
aad-access-key
branch
from
976799d to
d6bcc5a
Compare
terencefan
changed the title
terencefan
force-pushed
the
aad-access-key
branch
10 times, most recently
from
202f138 to
1c7b1f5
Compare
vicancy
reviewed
May 26, 2022
src/Microsoft.Azure.SignalR.Common/Utilities/ConnectionStringParser.cs
Outdated
Show resolved
Hide resolved
terencefan
force-pushed
the
aad-access-key
branch
from
1c7b1f5 to
c6ca006
Compare
vicancy
approved these changes
May 26, 2022
terencefan
added a commit
that referenced
this pull request
Jun 6, 2022
* code cleanup before refactor parser (#1617) * Add authtypes (azure, azure.msi, azure.app) (#1616) * Promote client connection trace to info (#1620) Co-authored-by: Liangying.Wei <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For historical reasons, we will use
ManagedIdentityCredentialby default when usingtype=aadwith no other designated params. It is NOT a best practice with the latestmsallibrary anymore.We added
type=azurein this PR to change the default behavior, the oldtype=aadwill be deprecated and removed in future releases.