Skip to content

Conversation

@danieljurek
Copy link
Member

No description provided.

@danieljurek danieljurek self-assigned this Nov 14, 2025
Copilot AI review requested due to automatic review settings November 14, 2025 22:26
@danieljurek danieljurek requested a review from a team as a code owner November 14, 2025 22:26
@danieljurek danieljurek moved this from 🤔 Triage to 🔬 Dev in PR in Azure SDK EngSys 🍔🌭 Nov 14, 2025
Copilot finished reviewing on behalf of danieljurek November 14, 2025 22:28
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds cspell upgrade verification functionality to the spell-checking pipeline template. When enabled, it validates that upgrades to the cspell package do not introduce new spelling errors in public APIs.

  • Added new parameters to control cspell upgrade verification behavior
  • Implemented a workflow to compare public API spelling errors before and after cspell upgrades
  • Added artifact publishing for upgrade verification results

@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

Copy link
Member

@weshaggard weshaggard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't be needed.

@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

and(
succeeded(),
ne('true', variables['Skip.SpellCheck']),
ne('', parameters.ScriptToValidateUpgrade)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Might be better to have this condition to be a template condition so this step doesn't show up for any repos other than js/.NET.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: 🔬 Dev in PR

Development

Successfully merging this pull request may close these issues.

4 participants