-
Notifications
You must be signed in to change notification settings - Fork 220
Add cspell upgrade check in check-spelling.yml #12910
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds cspell upgrade verification functionality to the spell-checking pipeline template. When enabled, it validates that upgrades to the cspell package do not introduce new spelling errors in public APIs.
- Added new parameters to control cspell upgrade verification behavior
- Implemented a workflow to compare public API spelling errors before and after cspell upgrades
- Added artifact publishing for upgrade verification results
|
The following pipelines have been queued for testing: |
|
The following pipelines have been queued for testing: |
weshaggard
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't be needed.
|
The following pipelines have been queued for testing: |
| and( | ||
| succeeded(), | ||
| ne('true', variables['Skip.SpellCheck']), | ||
| ne('', parameters.ScriptToValidateUpgrade) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: Might be better to have this condition to be a template condition so this step doesn't show up for any repos other than js/.NET.
No description provided.