Skip to content

Conversation

@haolingdong-msft
Copy link
Member

@haolingdong-msft haolingdong-msft commented Apr 21, 2023

Description

Link #34243

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@azure-sdk
Copy link
Collaborator

API change check

API changes are not detected in this pull request.

@weidongxu-microsoft
Copy link
Member

weidongxu-microsoft commented Apr 21, 2023

I assume we can actually check it in.

@haolingdong-msft haolingdong-msft marked this pull request as ready for review April 23, 2023 02:30
@haolingdong-msft
Copy link
Member Author

haolingdong-msft commented Apr 23, 2023

Hi @samvaity , this is our first package that adopts testproxy, this pr includes update test code and recordings. Please help to review and approve.

@joshfree
Copy link
Member

Thank you @haolingdong-msft and @weidongxu-microsoft for starting the onboarding process to testproxy!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants