[AppConfig] Re-record tests with Test proxy #33902
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
API change check API changes are not detected in this pull request. |
samvaity
force-pushed
the
app-config-re-record
branch
3 times, most recently
from
4001c6c to
e6b16b2
Compare
Member
Author
|
/azp run java - appconfiguration - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
samvaity
force-pushed
the
app-config-re-record
branch
2 times, most recently
from
5a66a9b to
c627ee9
Compare
samvaity
force-pushed
the
app-config-re-record
branch
from
c627ee9 to
b43321c
Compare
samvaity
force-pushed
the
app-config-re-record
branch
3 times, most recently
from
9aabee7 to
415a1a3
Compare
billwert
suggested changes
Apr 10, 2023
Contributor
billwert
left a comment
billwert
left a comment
There was a problem hiding this comment.
see comments. I think you may need to tell interceptorManager about the HttpClient in use. Otherwise looks great!
...-appconfiguration/src/test/java/com/azure/data/appconfiguration/ConfigurationClientTest.java
Outdated
Show resolved
Hide resolved
Contributor
There was a problem hiding this comment.
Same idea - add calling setHttpClient somewhere.
mssfang
reviewed
Apr 10, 2023
...onfiguration/src/test/java/com/azure/data/appconfiguration/ConfigurationAsyncClientTest.java
Outdated
Show resolved
Hide resolved
samvaity
force-pushed
the
app-config-re-record
branch
from
72cd7f6 to
2acd440
Compare
mssfang
approved these changes
Apr 17, 2023
billwert
approved these changes
Apr 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.