Skip to content

[Release] sdk/resourcemanager/sql/armsql/2.0.0-beta.7 #25012

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

azure-sdk
Copy link
Collaborator

… spec commit: f8675064e8e11818c65a5771b93d66984a2d0959
@Copilot Copilot AI review requested due to automatic review settings July 26, 2025 01:12
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR is a beta release version 2.0.0-beta.7 of the Azure SQL ARM SDK for Go. The changes include removing the Go 1.18 build constraints and implementing a new interception pattern in fake server transport code for testing purposes.

  • Remove build tags and update Go version compatibility requirements
  • Implement a new intercept-based fake server pattern across multiple service transports
  • Add context-aware concurrent request handling in fake servers

Reviewed Changes

Copilot reviewed 195 out of 464 changed files in this pull request and generated no comments.

File Description
sdk/resourcemanager/sql/armsql/fake/*.go Multiple fake server files removing Go 1.18 build constraints and implementing new interception pattern with goroutines and channels
sdk/resourcemanager/sql/armsql/fake/server_factory.go Added detailed comments for all server fields in the ServerFactory struct
sdk/resourcemanager/sql/armsql/fake/replicationlinks_server.go Updated HTTP status codes for delete operations and implemented interception pattern
sdk/resourcemanager/sql/armsql/fake/managedinstancetdecertificates_server.go Updated HTTP status codes and added interception pattern
Comments suppressed due to low confidence (1)

sdk/resourcemanager/sql/armsql/fake/managedserverdnsaliases_server.go:86

  • The variable name 'managedServerDnsAliasesServerTransportInterceptor' is inconsistent with the pattern used in other files. It should be 'managedServerDNSAliasesServerTransportInterceptor' to match the struct name 'ManagedServerDNSAliasesServerTransport'.
		if managedServerDnsAliasesServerTransportInterceptor != nil {

Copy link

API Change Check

APIView identified API level changes in this PR and created the following API reviews

sdk/resourcemanager/sql/armsql

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant