Skip to content

Conversation

AhmedBM
Copy link
Contributor

@AhmedBM AhmedBM commented Oct 9, 2025

Description

  • Remove explicit compiler paths as these paths will differ on certain distros - Needed to unblock 2510 release

Checklist

  • I have read the contribution guidelines.
  • I added unit-tests to validate my changes. All unit tests are passing.
  • I have merged the latest dev branch prior to this PR submission.
  • I ran pre-commit on my changes prior to this PR submission.
  • I submitted this PR against the dev branch.

@AhmedBM AhmedBM requested review from a team as code owners October 9, 2025 21:43
Copy link

github-actions bot commented Oct 9, 2025

Test Results

 64 files  ±0   64 suites  ±0   56m 43s ⏱️ +13s
  8 tests ±0    5 ✅  - 3   0 💤 ±0  3 ❌ +3 
256 runs  ±0  231 ✅  - 3  22 💤 ±0  3 ❌ +3 

For more details on these failures, see this check.

Results for commit 548d7a8. ± Comparison against base commit adbdd06.

♻️ This comment has been updated with latest results.

Copy link
Contributor

@MariusNi MariusNi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@simonjaeger
Copy link
Contributor

Rather than removing this - is there a way to fix this?

@MariusNi MariusNi merged commit 13f5754 into dev Oct 10, 2025
111 of 116 checks passed
@AhmedBM
Copy link
Contributor Author

AhmedBM commented Oct 10, 2025

Rather than removing this - is there a way to fix this?

That IS the fix :) For the older distros we have gcc/g++ installed in different locations so we rely on CMake on resolving the compiler paths itself (its in the $PATH)

@AhmedBM AhmedBM deleted the ahbenmes/fix_ci_failures_compiler branch October 10, 2025 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants