Allow usage of ObjectSerializer for Cosmos bindings #3163
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue describing the changes in this PR
resolves #2911
Pull request checklist
release_notes.md
Additional information
Addresses an issue with CosmosDB extension where users could not customize JSON serialization when binding directly to a POCO.
Issue:
CosmosDBConverter
was not consuming any user-provided JSON serialization customization. This was a regression from #1924.Fix:
CosmosDBExtensionOptions
to provide aObjectSerializer
, defaulting toWorkerOptions.Serializer
if no serializer is explicitly set.CosmosDBConverter
to use this new serializer when deserializing POCOsConcerns / Discussion:
This is a fix for a regression introduced back in December 2023. But it COULD be seen as a new breaking behavior change for some customers. This poses some risk for this change.