Skip to content

[SourceGen] Parse booleans in named arguments correctly #2234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jan 25, 2024
Merged

[SourceGen] Parse booleans in named arguments correctly #2234

merged 4 commits into from
Jan 25, 2024

Conversation

@satvu
Copy link
Member

@satvu satvu commented Jan 24, 2024 •
edited
Loading

Issue describing the changes in this PR

Booleans in named arguments of an attribute should be left as is in the raw bindings of function metadata. They should not be converted into strings as this has implications on some other components downstream.

Pull request checklist

  • My changes do not require documentation changes
    • Otherwise: Documentation issue linked to PR
  • My changes should not be added to the release notes for the next release
    • Otherwise: I've added my notes to release_notes.md
  • My changes do not need to be backported to a previous version
    • Otherwise: Backport tracked by issue/PR #issue_or_pr
  • I have added all required tests (Unit tests, E2E tests)

@satvu satvu force-pushed the satvu/bool-named-arg-fix branch from 115f7f9 to c3d0a0f Compare January 24, 2024 23:25
@satvu satvu requested review from fabiocav, jviau and kshyju January 24, 2024 23:26
fabiocav
fabiocav approved these changes Jan 25, 2024
View reviewed changes
Copy link
Member

@fabiocav fabiocav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving with a small nit

@satvu satvu requested a review from kshyju January 25, 2024 18:59
@satvu satvu merged commit 4f29778 into main Jan 25, 2024
@satvu satvu deleted the satvu/bool-named-arg-fix branch January 25, 2024 19:38
@sanjaybhagia sanjaybhagia mentioned this pull request Feb 6, 2024
Closed
@Davee02 Davee02 mentioned this pull request Feb 7, 2024
Closed
@kshyju kshyju mentioned this pull request Feb 9, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kshyju kshyju kshyju approved these changes

@fabiocav fabiocav fabiocav approved these changes

@jviau jviau Awaiting requested review from jviau

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@satvu @kshyju @fabiocav