Hedging: Fixes Concurrency Issue #5189
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NaluTripician
added
the
Hedging
NaluTripician
requested review from
FabianMeiswinkel,
Pilchie,
adityasa,
kirankumarkolli,
kirillg,
neildsh and
sboshra
as code owners
|
I thought your previous PR |
Context: In an offline discussion we decided to only take some of the changes with that PR and create a new one. |
...soft.Azure.Cosmos/src/Routing/AvailabilityStrategy/CrossRegionHedgingAvailabilityStrategy.cs
Outdated
Show resolved
Hide resolved
...soft.Azure.Cosmos/src/Routing/AvailabilityStrategy/CrossRegionHedgingAvailabilityStrategy.cs
Outdated
Show resolved
Hide resolved
...soft.Azure.Cosmos/src/Routing/AvailabilityStrategy/CrossRegionHedgingAvailabilityStrategy.cs
Show resolved
Hide resolved
kirankumarkolli
previously approved these changes
May 9, 2025
kirankumarkolli
changed the title
aavasthy
previously approved these changes
May 9, 2025
NaluTripician
changed the title
NaluTripician
dismissed stale reviews from FabianMeiswinkel, aavasthy, and kirankumarkolli
via
cd38683
kirankumarkolli
approved these changes
May 9, 2025
microsoft-github-policy-service
bot
deleted the
users/nalutripician/hedgingConcurrency
branch
This was referenced May 20, 2025
This was referenced Jun 19, 2025
System.ArgumentException: An item with the same key has already been added. Key: ApplicationId
#5224
Closed
This was referenced Jul 28, 2025
Closed
This was referenced Aug 4, 2025
Closed
This was referenced Aug 19, 2025
This was referenced Sep 1, 2025
This was referenced Oct 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Description
This pull request refactors the
CrossRegionHedgingAvailabilityStrategyclass in the Azure Cosmos SDK to fix a rare concurrency issue regarding session tokens and improve diagnostics for improved debugging.. It also updates related tests to align with the changes. The most important changes include replacing theResponse Regiondiagnostic with a newHedge Configdiagnostic, modifying theHedgingResponseclass, and updating test cases to validate the new behavior. theResponse Regionfield can sometimes be inaccurate with internal cross regional retries so it has been removed. To find the response region, you can look at the existing store response to see where the response came from.Type of change
Please delete options that are not relevant.
Closing issues
To automatically close an issue: closes #IssueNumber