Skip to content

Query: Fixes function signature for RRF, OrderByRank and FullTextScore LINQ extension methods #5163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 2, 2025

Conversation

leminh98
Copy link
Contributor

@leminh98 leminh98 commented May 1, 2025

Pull Request Template

Description

This PR changes the function signature for RRF, OrderByRank and FullTextScore for LINQ extension methods to more closely align with vector distance

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • [] New feature (non-breaking change which adds functionality)
  • [] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [] This change requires a documentation update

Closing issues

To automatically close an issue: closes #IssueNumber

@leminh98 leminh98 added the auto-merge Enables automation to merge PRs label May 1, 2025
@microsoft-github-policy-service microsoft-github-policy-service bot enabled auto-merge (squash) May 1, 2025 23:14
@adityasa
Copy link
Contributor

adityasa commented May 2, 2025

  <ErrorMessage><![CDATA[Status Code: BadRequest,{"errors":[{"severity":"Error","location":{"start":34,"end":96},"code":"SC2221","message":"The ORDER BY RANK clause must be followed by a VectorDistance and/or a FullTextScore function call."}]},0x800A0B00]]></ErrorMessage>

Why is this query invalid?


Refers to: Microsoft.Azure.Cosmos/tests/Microsoft.Azure.Cosmos.EmulatorTests/BaselineTest/TestBaseline/LinqTranslationBaselineTests.TestRRFOrderByRankFunction.xml:44 in 2a9edb1. [](commit_id = 2a9edb1, deletion_comment = False)

adityasa
adityasa previously approved these changes May 2, 2025
Copy link
Contributor

@adityasa adityasa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@leminh98
Copy link
Contributor Author

leminh98 commented May 2, 2025

  <ErrorMessage><![CDATA[Status Code: BadRequest,{"errors":[{"severity":"Error","location":{"start":34,"end":96},"code":"SC2221","message":"The ORDER BY RANK clause must be followed by a VectorDistance and/or a FullTextScore function call."}]},0x800A0B00]]></ErrorMessage>

That's the error message from the BE. Invalid because RRF only was supplied one function


In reply to: 2847511423


Refers to: Microsoft.Azure.Cosmos/tests/Microsoft.Azure.Cosmos.EmulatorTests/BaselineTest/TestBaseline/LinqTranslationBaselineTests.TestRRFOrderByRankFunction.xml:44 in 2a9edb1. [](commit_id = 2a9edb1, deletion_comment = False)

Copy link
Contributor

@adityasa adityasa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-merge Enables automation to merge PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants