Skip to content

Query: Adds support for LINQ extension method for VectorDistance #5157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
May 16, 2025
Merged

Query: Adds support for LINQ extension method for VectorDistance #5157

merged 13 commits into from
May 16, 2025

Conversation

leminh98
Copy link
Contributor

@leminh98 leminh98 commented May 1, 2025

Pull Request Template

Description

This PR adds LINQ extension method for VectorDistance. There are 3 interface corresponding to the 3 different type supported for VectorDistance. Usage example:

var distance = documents.Select(document => document.vector1.VectorDistance(<vector2>, true, {'distanceFunction':'cosine', 'dataType':'float32'}));

Refer to the unit test for more examples.

Type of change

Please delete options that are not relevant.

  • [] Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • [] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [] This change requires a documentation update

Closing issues

To automatically close an issue: closes #IssueNumber

@leminh98 leminh98 added the auto-merge Enables automation to merge PRs label May 1, 2025
@microsoft-github-policy-service microsoft-github-policy-service bot enabled auto-merge (squash) May 1, 2025 10:19
adityasa
adityasa reviewed May 7, 2025
View reviewed changes
adityasa
adityasa reviewed May 7, 2025
View reviewed changes
adityasa
adityasa reviewed May 8, 2025
View reviewed changes
adityasa
adityasa reviewed May 8, 2025
View reviewed changes
adityasa
adityasa reviewed May 8, 2025
View reviewed changes
adityasa
adityasa reviewed May 8, 2025
View reviewed changes
@leminh98 leminh98 requested a review from Pilchie as a code owner May 8, 2025 18:05
sboshra
sboshra previously approved these changes May 9, 2025
View reviewed changes
Copy link
Contributor

@sboshra sboshra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

adityasa
adityasa reviewed May 9, 2025
View reviewed changes
Microsoft.Azure.Cosmos/src/Linq/BuiltinFunctions/OtherBuiltinSystemFunctions.cs Outdated

if (methodCallExpression.Arguments[3] is ConstantExpression optionExpression && optionExpression.Value != null)
{
string serializedConstant = System.Text.Json.JsonSerializer.Serialize(
Copy link
Contributor

@adityasa adityasa May 9, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

System.Text.Json

Nit, full qualification not required. #Resolved

adityasa
adityasa reviewed May 9, 2025
View reviewed changes
Microsoft.Azure.Cosmos/src/Resource/Settings/DistanceFunction.cs Outdated
/// <summary>
/// Represents default value.
/// </summary>
None,
Copy link
Contributor

@adityasa adityasa May 9, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure other consumers of this class would work ok with this value. #Pending

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we need, we can create a copy of this enum in CosmosLinqExtensions class/namespace.

adityasa
adityasa reviewed May 9, 2025
View reviewed changes
Microsoft.Azure.Cosmos/src/Resource/Settings/VectorDataType.cs Outdated
/// <summary>
/// Represents default value.
/// </summary>
None,
Copy link
Contributor

@adityasa adityasa May 9, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

None

I am not sure other consumers of this class would work ok with this value. #Pending

@adityasa adityasa dismissed stale reviews from kirankumarkolli and sboshra via 7ea77cb May 14, 2025 20:13
This was referenced Jul 28, 2025
Closed
Closed
Open
Open
Open
Open
This was referenced Aug 4, 2025
Open
Open
Closed
Open
Closed
This was referenced Aug 15, 2025
Merged
Merged
Merged
Merged
Closed
Merged
Open
Open
Closed
Closed
Merged
Closed
Open
Open
Open
This was referenced Aug 25, 2025
Open
Merged
Merged
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kirankumarkolli kirankumarkolli kirankumarkolli approved these changes

@adityasa adityasa adityasa approved these changes

@sboshra sboshra sboshra approved these changes

@neildsh neildsh neildsh approved these changes

@khdang khdang Awaiting requested review from khdang khdang is a code owner

@FabianMeiswinkel FabianMeiswinkel Awaiting requested review from FabianMeiswinkel FabianMeiswinkel is a code owner

@kirillg kirillg Awaiting requested review from kirillg kirillg is a code owner

@Pilchie Pilchie Awaiting requested review from Pilchie

Assignees
No one assigned
Labels
auto-merge Enables automation to merge PRs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@leminh98 @kirankumarkolli @adityasa @sboshra @neildsh