[Internal] Binary Encoding: Fixes Serialization Gaps on Newtonsoft Reader/Writer for Transactional Batch #5030
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kundadebdatta
added
auto-merge
kundadebdatta
requested review from
khdang,
sboshra,
adityasa,
neildsh,
kirankumarkolli,
FabianMeiswinkel,
kirillg and
Pilchie
as code owners
Microsoft.Azure.Cosmos/tests/Microsoft.Azure.Cosmos.EmulatorTests/CosmosItemIntegrationTests.cs
Show resolved
Hide resolved
Microsoft.Azure.Cosmos/src/Json/Interop/CosmosDBToNewtonsoftReader.cs
Outdated
Show resolved
Hide resolved
Microsoft.Azure.Cosmos/src/Json/Interop/CosmosDBToNewtonsoftReader.cs
Outdated
Show resolved
Hide resolved
sboshra
reviewed
Feb 24, 2025
Microsoft.Azure.Cosmos/src/Json/Interop/CosmosDBToNewtonsoftReader.cs
Outdated
Show resolved
Hide resolved
microsoft-github-policy-service
bot
deleted the
users/dkunda/5021_fix_binary_newtonsoft_writer
branch
kundadebdatta
added a commit
that referenced
this pull request
Feb 28, 2025
…ader/Writer for Transactional Batch (#5030) # Pull Request Template ## Description This PR fixes the following: - Fixes the serialization Gaps on `CosmosDBToNewtonsoftReader` and `CosmosDBToNewtonsoftWriter` for byte[] array read and write respectively. - Wraps the transactional batch operation result output stream into a `CloneableStream` to de-serialize accurately, when binary encoding is enabled. ## Type of change Please delete options that are not relevant. - [x] Bug fix (non-breaking change which fixes an issue) ## Closing issues To automatically close an issue: closes #5021
1 task
microsoft-github-policy-service bot
pushed a commit
that referenced
this pull request
Feb 28, 2025
…er/Writer for Transactional Batch (#5041) # Pull Request Template ## Description This PR cherry-picks the following commits: - #5030 ## Type of change Please delete options that are not relevant. - [x] Bug fix (non-breaking change which fixes an issue) ## Closing issues To automatically close an issue: closes #IssueNumber
This was referenced Jul 28, 2025
This was referenced Jul 28, 2025
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Description
This PR fixes the following:
Fixes the serialization Gaps on
CosmosDBToNewtonsoftReaderandCosmosDBToNewtonsoftWriterfor byte[] array read and write respectively.Wraps the transactional batch operation result output stream into a
CloneableStreamto de-serialize accurately, when binary encoding is enabled.Type of change
Please delete options that are not relevant.
Closing issues
To automatically close an issue: closes #5021