CF/P AVAD: Fixes Deserialization of ChangeFeedItem and ChangeFeedMetadata to support System.Text.Json and Newtonsoft.Json

Microsoft.Azure.Cosmos/src/Resource/FullFidelity/ChangeFeedItem.cs

@@ -4,8 +4,6 @@
 
 namespace Microsoft.Azure.Cosmos
 {
-    using Newtonsoft.Json;
-
     /// <summary>
     /// The typed response that contains the current, previous, and metadata change feed resource when <see cref="ChangeFeedMode"/> is initialized to <see cref="ChangeFeedMode.AllVersionsAndDeletes"/>.
     /// </summary>
@@ -58,19 +56,16 @@ class ChangeFeedItem<T>
         /// <summary>
         /// The full fidelity change feed current item.
         /// </summary>
-        [JsonProperty(PropertyName = "current")]
         public T Current { get; set; }
 
         /// <summary>
         /// The full fidelity change feed metadata.
         /// </summary>
-        [JsonProperty(PropertyName = "metadata", NullValueHandling = NullValueHandling.Ignore)]
         public ChangeFeedMetadata Metadata { get; set; }
 
         /// <summary>
         /// For delete operations, previous image is always going to be provided. The previous image on replace operations is not going to be exposed by default and requires account-level or container-level opt-in.
         /// </summary>
-        [JsonProperty(PropertyName = "previous", NullValueHandling = NullValueHandling.Ignore)]
         public T Previous { get; set; }
     }
 }

Microsoft.Azure.Cosmos/src/Resource/FullFidelity/ChangeFeedMetadata.cs

@@ -4,51 +4,61 @@
 
 namespace Microsoft.Azure.Cosmos
 {
-    using System;
-    using Microsoft.Azure.Documents;
-    using Newtonsoft.Json;
-    using Newtonsoft.Json.Converters;
-
     /// <summary>
     /// The metadata of a change feed resource with <see cref="ChangeFeedMode"/> is initialized to <see cref="ChangeFeedMode.AllVersionsAndDeletes"/>.
     /// </summary>
 #if PREVIEW
     public
 #else
     internal
-#endif 
+#endif
         class ChangeFeedMetadata
     {
+        /// <summary>
+        /// New instance of meta data for <see cref="ChangeFeedItem{T}"/> created.
+        /// </summary>
+        /// <param name="crts"></param>
+        /// <param name="lsn"></param>
+        /// <param name="operationType"></param>
+        /// <param name="previousImageLSN"></param>
+        /// <param name="timeToLiveExpired"></param>
+        public ChangeFeedMetadata(
+            long crts,
+            long lsn,
+            ChangeFeedOperationType operationType,
+            long previousImageLSN,
+            bool timeToLiveExpired)
+        {
+            this.Crts = crts;
+            this.Lsn = lsn;
+            this.OperationType = operationType;
+            this.PreviousImageLSN = previousImageLSN;
+            this.TimeToLiveExpired = timeToLiveExpired;
+        }
+
         /// <summary>
         /// The conflict resolution timestamp.
         /// </summary>
-        [JsonProperty(PropertyName = "crts", NullValueHandling = NullValueHandling.Ignore)]
-        [JsonConverter(typeof(UnixDateTimeConverter))]
-        public DateTime ConflictResolutionTimestamp { get; internal set; }
+        public long Crts { get; }
 
         /// <summary>
         /// The current logical sequence number.
         /// </summary>
-        [JsonProperty(PropertyName = "lsn", NullValueHandling = NullValueHandling.Ignore)]
-        public long Lsn { get; internal set;  }
+        public long Lsn { get; }
 
         /// <summary>
         /// The change feed operation type.
         /// </summary>
-        [JsonProperty(PropertyName = "operationType")]
-        [JsonConverter(typeof(StringEnumConverter))]
-        public ChangeFeedOperationType OperationType { get; internal set; }
+        public ChangeFeedOperationType OperationType { get; }
 
         /// <summary>
         /// The previous logical sequence number.
         /// </summary>
-        [JsonProperty(PropertyName = "previousImageLSN", NullValueHandling = NullValueHandling.Ignore)]
-        public long PreviousLsn { get; internal set; }
+        public long PreviousImageLSN { get; }
 
         /// <summary>
         /// Used to distinquish explicit deletes (e.g. via DeleteItem) from deletes caused by TTL expiration (a collection may define time-to-live policy for documents).
         /// </summary>
-        [JsonProperty(PropertyName = "timeToLiveExpired", NullValueHandling= NullValueHandling.Ignore)]
-        public bool IsTimeToLiveExpired { get; internal set; }
+        public bool TimeToLiveExpired { get; }
     }
 }