-
Notifications
You must be signed in to change notification settings - Fork 517
CFP AVAD: Adds Container IsFeedRangePartOfAsync support for FeedRange #4566
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
microsoft-github-policy-service
merged 178 commits into
master
from
users/philipthomas-MSFT/add_feedranges_to_avad_contract
Oct 4, 2024
+1,686
−6
Merged
Changes from all commits
Commits
Show all changes
178 commits
Select commit
Hold shift + click to select a range
a71d474
initial checkin
philipthomas-MSFT 749c7ff
feedRangeFetails added to headers as a tuple. may created a public ty…
philipthomas-MSFT 158b26d
FeedRangeDetail type in place of tuple
philipthomas-MSFT 5472e18
some tests but impl is incomplete
philipthomas-MSFT 1889f0f
merge
philipthomas-MSFT 5e3f277
merge
philipthomas-MSFT 02b220e
revert after bad merge
philipthomas-MSFT ae7ea26
revert after a bad merge
philipthomas-MSFT 003da7e
revert after a bad merge
philipthomas-MSFT 4af2d91
changes
philipthomas-MSFT 96262c0
more test to come
philipthomas-MSFT 00e32d3
add a test for FeedRange on Header, Find overlapping ranges using Par…
philipthomas-MSFT 8fc8608
removing the type FeedRangeDetails, collectionRId was not needed.
philipthomas-MSFT d62f05f
mark as Preview
philipthomas-MSFT 76ee8f0
FindOverlappingRanges test. Just FeedRange.
philipthomas-MSFT 5b2cd52
The start, not finished, test for container.FindOverlappingRangesAsync
philipthomas-MSFT 18ce956
partition key tests
philipthomas-MSFT b1ed9a1
more testing. still not satisfied. will do more until the end of week.
philipthomas-MSFT df0eb32
more test changes.
philipthomas-MSFT 77be0f9
add partitionkey to test
philipthomas-MSFT 570d5ea
Merge remote-tracking branch 'origin/master' into users/philipthomas-…
philipthomas-MSFT e3e3f23
Merge branch 'master' into users/philipthomas-MSFT/add_feedranges_to_…
philipthomas-MSFT 5976251
merge master
philipthomas-MSFT a026438
merge master
philipthomas-MSFT 843be8f
re-run UpdateContracts.ps1
philipthomas-MSFT 5cbb0d6
more tests alterations.
philipthomas-MSFT caff01e
add cancellation token to test.
philipthomas-MSFT 4cf2fea
just some test changes
philipthomas-MSFT 0c56179
fix issue with FeedRangeEpk
philipthomas-MSFT 563ddb9
some test changes from meeting.
philipthomas-MSFT 73b912a
re-run update contracts.
philipthomas-MSFT 771c487
making it work.
philipthomas-MSFT 6559eb0
sdd to EncryptionContainer.cs
philipthomas-MSFT 5e2a0b6
some formatting and change to Debug for logging before Logger.LogLine…
philipthomas-MSFT bda2f44
test update
philipthomas-MSFT f5016d8
Merge branch 'master' into users/philipthomas-MSFT/add_feedranges_to_…
philipthomas-MSFT b02f35a
fix EncryptionContainer
philipthomas-MSFT b5a65c8
remove a test helper method that is no longer needed. and updated tes…
philipthomas-MSFT 9cee550
trying to fix EncryptionContainer
philipthomas-MSFT 1efe714
try, try again
philipthomas-MSFT 0b0001b
hmm
philipthomas-MSFT 8fc3537
fixing a test.
philipthomas-MSFT f4745af
Merge branch 'master' into users/philipthomas-MSFT/add_feedranges_to_…
philipthomas-MSFT 9d3fb3e
Merge branch 'master' into users/philipthomas-MSFT/add_feedranges_to_…
philipthomas-MSFT c848800
removing other features and boiling it down to just FindOverlappingRa…
philipthomas-MSFT ce57c96
Merge remote-tracking branch 'origin/master' into users/philipthomas-…
philipthomas-MSFT 490fe03
move rangeFromPartitionKey out of loop.
philipthomas-MSFT 90a6232
Merge remote-tracking branch 'origin/master' into users/philipthomas-…
philipthomas-MSFT 6556dc6
Merge remote-tracking branch 'origin/master' into users/philipthomas-…
philipthomas-MSFT e57ce18
IsSubset
philipthomas-MSFT cc4c4f3
Merge remote-tracking branch 'origin/master' into users/philipthomas-…
philipthomas-MSFT 64ba764
removed from Encryption
philipthomas-MSFT f5fc5bb
add back GetChangeFeedProcessorBuilderWithAllVersionsAndDeletes<T>
philipthomas-MSFT 5fe347f
reverting back to origin
philipthomas-MSFT df9fecd
NotImplementedException>() fix on container
philipthomas-MSFT 78618cd
reverting sln
philipthomas-MSFT 1378a55
hmm. these baseline files.
philipthomas-MSFT a9d59a2
revwer to origin
philipthomas-MSFT b45f34b
removed api for PartitionKey since user can call FeedRange.FromPartit…
philipthomas-MSFT fb05663
reworked IsSubsetAsync based on suggestions to use FeedRangeInteranl …
philipthomas-MSFT 50185b6
Merge remote-tracking branch 'origin/master' into users/philipthomas-…
philipthomas-MSFT 77a1897
some subset changes. and tests.
philipthomas-MSFT 8f07db8
missing using directive
philipthomas-MSFT 6aa9487
type Overlaps instead of dynamic type. Fix IsSubset to include equal to.
philipthomas-MSFT 8e96a69
Overlaps list
philipthomas-MSFT 72770f2
update logic for IsSubset
philipthomas-MSFT 83992d8
removed Overlap type. No longer needed.
philipthomas-MSFT a7119a2
ArgumentException to include expect and actual type.
philipthomas-MSFT 354dbbe
include basic code sample references in code-doc.
philipthomas-MSFT 7026c3b
default argument for CancellationToken parameter
philipthomas-MSFT 68e15c5
removed NoOpTrace
philipthomas-MSFT efc7c8c
another default argument for CancellationToken parameter
philipthomas-MSFT bd8f56a
discovering the smallest Min and the largest Max from an array of Doc…
philipthomas-MSFT 36c3e5f
some refactoring. also dealing with ranges that are FeedRangePartitio…
philipthomas-MSFT 74f7fab
removed an unnecessary getEffectoveRamgesAsync call.
philipthomas-MSFT 8cfd9f3
Merge remote-tracking branch 'origin/master' into users/philipthomas-…
philipthomas-MSFT a381687
not sure why this changed.
philipthomas-MSFT edf36d4
hmm. add try catch back.
philipthomas-MSFT c3e8d64
Merge branch 'master' of https://github.com/Azure/azure-cosmos-dotnet…
philipthomas-MSFT bbed6d4
name refactoring. TryParse on parent and child json. DocumentClientEx…
philipthomas-MSFT 53848de
validation and error checks with tests.
philipthomas-MSFT 683bebb
rename refactoring
philipthomas-MSFT 0eef412
unused using directives.
philipthomas-MSFT 3606d62
Normalized Ranges impl
philipthomas-MSFT 4f59d6a
more tests
philipthomas-MSFT 976e21f
remove comment and alias. not necessary. using Last.Max to avoid reso…
philipthomas-MSFT 0d70411
IsMinInclusive check on FeedRangeEpk. remove normalization of FeedRange
philipthomas-MSFT 8a8f229
removed usings
philipthomas-MSFT 5e33500
Merge branch 'master' into users/philipthomas-MSFT/add_feedranges_to_…
philipthomas-MSFT d5a999b
ok. should add these usings back.
philipthomas-MSFT c2e6d52
test updates. documentation for clarity. some refactoring.
philipthomas-MSFT 5b60151
IsSubset tests
philipthomas-MSFT 46db601
Add Display. a nit.
philipthomas-MSFT 4d84158
no idea why I changed this.
philipthomas-MSFT fff0458
EnsureConsistentInclusivity
philipthomas-MSFT 3463fab
various changes. PREVIEW. FeedRangeInternal check before TryParse on …
philipthomas-MSFT 58d1122
moving test to create a single instance of Containers
philipthomas-MSFT c43d063
removed duplicated test data row.
philipthomas-MSFT b6e5e29
removal of unnecessary comments since I am describing the scenarios.
philipthomas-MSFT f860d12
missed a container instance
philipthomas-MSFT 801c1a8
missed another container reference
philipthomas-MSFT 4c84f8e
revert since new tests have new tests file
philipthomas-MSFT c6bff5b
Merge branch 'master' into users/philipthomas-MSFT/add_feedranges_to_…
philipthomas-MSFT 846dfb4
add another test scenario
philipthomas-MSFT 91708f9
fix displayname
philipthomas-MSFT 769c8e4
more scenarios
philipthomas-MSFT e0319dd
move ensureConsistentInclusivity to check on effectiveRanges outside …
philipthomas-MSFT e7bde88
adding comments, but thinking of a better way to deal and manage this…
philipthomas-MSFT 4b3b079
introducing Gherkin interpreter to have a discussion with Team to see…
philipthomas-MSFT bfa9740
remove gherkin. will follow up on dynamic building of scenarios.
philipthomas-MSFT 003a17d
Merge branch 'master' into users/philipthomas-MSFT/add_feedranges_to_…
philipthomas-MSFT b82a731
reverting to master
philipthomas-MSFT a45b646
new tests for IsSubset with strategy for creating inclusive or exclus…
philipthomas-MSFT 4f50db2
removed from EncryptionContainer
philipthomas-MSFT 5e68c03
need to fix a test.
philipthomas-MSFT 0735b65
revert test.
philipthomas-MSFT 3783530
adding this back
philipthomas-MSFT 3a2608c
encryption container fix
philipthomas-MSFT b553c72
add more comments
philipthomas-MSFT f2ea6c4
fix broken test
philipthomas-MSFT 43ffba1
add impl
philipthomas-MSFT 2a3a197
reverting
philipthomas-MSFT feaeb8f
virutal on Container. some things may fail.
philipthomas-MSFT dfe5feb
Merge branch 'master' into users/philipthomas-MSFT/add_feedranges_to_…
kirankumarkolli 6d77041
change test for IsSubset again. Not dynamic anymore.
philipthomas-MSFT 2cd8d75
Merge branch 'users/philipthomas-MSFT/add_feedranges_to_avad_contract…
philipthomas-MSFT 05e87a0
update summary
philipthomas-MSFT 0876202
removed unnecessary comment
philipthomas-MSFT 4ffe30c
removed some scenarios
philipthomas-MSFT fb7b942
add PREVIEW flag
philipthomas-MSFT 0a8e36d
Merge branch 'master' into users/philipthomas-MSFT/add_feedranges_to_…
philipthomas-MSFT 7868ef6
updatecontracts
philipthomas-MSFT acbad19
include more scenarios
philipthomas-MSFT 6140a90
add verbage
philipthomas-MSFT f235378
add IsFeedRangePartofAsync in ContainerCore.
philipthomas-MSFT a7f048a
new scenarios to illustrate my point in conversation
philipthomas-MSFT 8497db9
add DisplayName for 2 DataRows
philipthomas-MSFT 35acb5f
since name changed from IsSubset to IsFeedRangePartOfAsync, fixing tr…
philipthomas-MSFT 1b17ab7
trying Diagram 2 with ContainerInternal instead of ContainerInlineCore
philipthomas-MSFT 76940cc
fix to IsSub and test that are affected.
philipthomas-MSFT 10898e0
overriding in ContainerInlineCore, but not using operations helper, etc.
philipthomas-MSFT 8790e7b
fix test implementation for IsSubset. add more DataRows
philipthomas-MSFT 3d8d306
issue with summary
philipthomas-MSFT b6ab81e
Merge branch 'master' into users/philipthomas-MSFT/add_feedranges_to_…
philipthomas-MSFT 5bbad51
removed Range<string> from summary
philipthomas-MSFT 07a294b
add more scenarios and reorganized the DataRows
philipthomas-MSFT 5bb871b
move some documentation around
philipthomas-MSFT a6d4eda
wrap async method in OperationHelperAsync for consistency
philipthomas-MSFT de79711
add TODO about Documents.OperationType.ReadFeed on operations not rel…
philipthomas-MSFT e5846c9
ranges is null empty so just pull the first one. also update summary.
philipthomas-MSFT e4790d4
Merge branch 'master' into users/philipthomas-MSFT/add_feedranges_to_…
philipthomas-MSFT 0169f4c
Merge branch 'master' into users/philipthomas-MSFT/add_feedranges_to_…
philipthomas-MSFT 4e2a95b
Merge branch 'master' into users/philipthomas-MSFT/add_feedranges_to_…
philipthomas-MSFT 6a5d8e7
add this scenario "AA", "AA", true, "", "AA", false, false
philipthomas-MSFT 56775bb
adding scenario "AA", "AA", true, "AA", "AZ", false, true
philipthomas-MSFT bed52de
all recent new scenarios
philipthomas-MSFT c9f2763
Merge branch 'master' into users/philipthomas-MSFT/add_feedranges_to_…
kirankumarkolli 8e008fb
made a change for isSubset to substract the max if MaxExclusive. spec…
philipthomas-MSFT bde2252
Merge branch 'master' into users/philipthomas-MSFT/add_feedranges_to_…
philipthomas-MSFT 8989c7b
Merge branch 'users/philipthomas-MSFT/add_feedranges_to_avad_contract…
philipthomas-MSFT 81e1499
renaiming parent and child to x and y, respectively, for Container.cs
philipthomas-MSFT 9dff5c5
test to include all types of containers.
philipthomas-MSFT 8aec5b9
Merge branch 'master' into users/philipthomas-MSFT/add_feedranges_to_…
kirankumarkolli fe03634
remove dead code.
philipthomas-MSFT 09fa5d0
fix params
philipthomas-MSFT 248b929
reverted these
philipthomas-MSFT ccc3009
remove named parameters because local test use parent/child parameter…
philipthomas-MSFT 48213d0
Merge branch 'master' into users/philipthomas-MSFT/add_feedranges_to_…
philipthomas-MSFT 77dab06
Update Microsoft.Azure.Cosmos/src/Resource/Container/Container.cs
philipthomas-MSFT 23bdc17
Update Microsoft.Azure.Cosmos/src/Resource/Container/ContainerCore.It…
philipthomas-MSFT 860dbc7
Merge branch 'master' into users/philipthomas-MSFT/add_feedranges_to_…
philipthomas-MSFT 10d6c9a
update docs
philipthomas-MSFT ba71dd0
Merge branch 'users/philipthomas-MSFT/add_feedranges_to_avad_contract…
philipthomas-MSFT 4ebbad9
change parent to x, and child to y, everywhere.
philipthomas-MSFT 2a63b12
Merge branch 'master' into users/philipthomas-MSFT/add_feedranges_to_…
philipthomas-MSFT 0c4df8e
removed extra params
philipthomas-MSFT 8441b34
extraa return removed
philipthomas-MSFT 855810b
done.
philipthomas-MSFT File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.