Query: Adds support for multi-value Group By query for LINQ #4481

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

microsoft-github-policy-service merged 19 commits into master from users/leminh/LINQGroupByMultiValue

Jul 9, 2024

Contributor

leminh98 commented May 13, 2024 •

edited

Loading

Pull Request Template

Description

This PR adds the ability to translate LINQ query to SQL query with multiple items in the SQL select clause. This is achieved through the value clause using NewExpression

Type of change

Please delete options that are not relevant.

[] Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
[] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[] This change requires a documentation update

Closing issues

To automatically close an issue: closes #IssueNumber

Minh Le (from Dev Box) added 5 commits

April 10, 2024 10:23


          init

51d41ad


          Added tests

d8e7125


          Preliminary code

f193d33


          merge with master

342daba


          baseline

138936f

leminh98 requested review from khdang, sboshra, adityasa, neildsh, kirankumarkolli, ealsur, FabianMeiswinkel and kirillg as code owners

May 13, 2024 00:57

leminh98 added QUERY auto-merge labels

microsoft-github-policy-service bot enabled auto-merge (squash)

May 13, 2024 00:58

Contributor

bartelink commented May 13, 2024

Semi-related issues in case they are easy to address in the same block of work:

Unable to Call DOCUMENTID(root) from LINQ provider #2607
Support LINQ querying for records #3728
(I'd love records support as it would let me remove some horrendous expression tree manipulation workarounds)

leminh98 mentioned this pull request

LINQ support for Group By #1202

Closed

Minh Le (from Dev Box) added 2 commits

May 13, 2024 15:28


          add ordering ignore to test cases

1954b51


          upate baseline

29a15de

adityasa reviewed

View reviewed changes

...ests/BaselineTest/TestBaseline/LinqGeneralBaselineTests.TestGroupByMultiValueTranslation.xml Outdated Show resolved Hide resolved

adityasa reviewed

View reviewed changes

...ests/BaselineTest/TestBaseline/LinqGeneralBaselineTests.TestGroupByMultiValueTranslation.xml Outdated Show resolved Hide resolved

adityasa reviewed

View reviewed changes

...ests/BaselineTest/TestBaseline/LinqGeneralBaselineTests.TestGroupByMultiValueTranslation.xml Outdated Show resolved Hide resolved

adityasa reviewed

View reviewed changes

...ests/BaselineTest/TestBaseline/LinqGeneralBaselineTests.TestGroupByMultiValueTranslation.xml Outdated Show resolved Hide resolved

adityasa reviewed

View reviewed changes

...ests/BaselineTest/TestBaseline/LinqGeneralBaselineTests.TestGroupByMultiValueTranslation.xml Show resolved Hide resolved

adityasa reviewed

View reviewed changes

...ests/BaselineTest/TestBaseline/LinqGeneralBaselineTests.TestGroupByMultiValueTranslation.xml Outdated Show resolved Hide resolved

adityasa reviewed

View reviewed changes

...ests/BaselineTest/TestBaseline/LinqGeneralBaselineTests.TestGroupByMultiValueTranslation.xml Show resolved Hide resolved

adityasa reviewed

View reviewed changes

...ests/BaselineTest/TestBaseline/LinqGeneralBaselineTests.TestGroupByMultiValueTranslation.xml Outdated Show resolved Hide resolved

adityasa reviewed

View reviewed changes

...ests/BaselineTest/TestBaseline/LinqGeneralBaselineTests.TestGroupByMultiValueTranslation.xml Outdated Show resolved Hide resolved

adityasa reviewed

View reviewed changes

...oft.Azure.Cosmos/tests/Microsoft.Azure.Cosmos.EmulatorTests/Linq/LinqGeneralBaselineTests.cs Outdated Show resolved Hide resolved

adityasa reviewed

View reviewed changes

Microsoft.Azure.Cosmos/src/Linq/ExpressionToSQL.cs Show resolved Hide resolved

Minh Le (from Dev Box) and others added 3 commits

May 21, 2024 03:17


          address code review 1

f6ab78c


          Changed the way comparison between Anonymoustype object worked. Also …

49afa87

…added handling of multivalue case to call directly to leaf layer visitors, instead of going through the top level scalar expression visitor to avoid changing binding and context scope


          Merge branch 'master' into users/leminh/LINQGroupByMultiValue

10c1fd8

adityasa reviewed

View reviewed changes

...ests/BaselineTest/TestBaseline/LinqGeneralBaselineTests.TestGroupByMultiValueTranslation.xml Show resolved Hide resolved

adityasa reviewed

View reviewed changes

Microsoft.Azure.Cosmos/tests/Microsoft.Azure.Cosmos.EmulatorTests/Linq/LinqTestsCommon.cs Show resolved Hide resolved

adityasa reviewed

View reviewed changes

Microsoft.Azure.Cosmos/tests/Microsoft.Azure.Cosmos.EmulatorTests/Linq/LinqTestsCommon.cs Show resolved Hide resolved

adityasa reviewed

View reviewed changes

Microsoft.Azure.Cosmos/tests/Microsoft.Azure.Cosmos.EmulatorTests/Linq/LinqTestsCommon.cs Outdated Show resolved Hide resolved

adityasa previously approved these changes

View reviewed changes

Contributor

adityasa left a comment

leminh98 added 2 commits

July 1, 2024 10:42


          addressed code review

c324414


          Merge branch 'users/leminh/LINQGroupByMultiValue' of https://github.c…

d25ec72

…om/Azure/azure-cosmos-dotnet-v3 into users/leminh/LINQGroupByMultiValue

leminh98 dismissed adityasa’s stale review via

d25ec72

July 1, 2024 17:43


          Merge branch 'master' into users/leminh/LINQGroupByMultiValue

019b8f2

adityasa reviewed

View reviewed changes

Microsoft.Azure.Cosmos/tests/Microsoft.Azure.Cosmos.EmulatorTests/Linq/LinqTestsCommon.cs Outdated Show resolved Hide resolved

adityasa previously approved these changes

View reviewed changes

leminh98 added 2 commits

July 2, 2024 11:54


          address code review

d19b519


          Merge branch 'users/leminh/LINQGroupByMultiValue' of https://github.c…

c5dd3be

…om/Azure/azure-cosmos-dotnet-v3 into users/leminh/LINQGroupByMultiValue

leminh98 dismissed adityasa’s stale review via

c5dd3be

July 2, 2024 18:55

leminh98 and others added 2 commits

July 2, 2024 12:51


          addressed missing field

de2eaf6


          Merge branch 'master' into users/leminh/LINQGroupByMultiValue

e1f456f

adityasa approved these changes

View reviewed changes


          Merge branch 'master' into users/leminh/LINQGroupByMultiValue

428adc2

Maya-Painter approved these changes

View reviewed changes


          Merge branch 'master' into users/leminh/LINQGroupByMultiValue

763e1b7

microsoft-github-policy-service bot merged commit 5bba9a0 into master

microsoft-github-policy-service bot deleted the users/leminh/LINQGroupByMultiValue branch

July 9, 2024 04:07

This was referenced Jul 28, 2025

Bump Azure.Identity and 6 others shibayan/nuget-lock-demo#2

Closed

Bump Azure.Extensions.AspNetCore.Configuration.Secrets and 17 others HassanFad/chat-copilot#32

Closed

dependabot bot mentioned this pull request

Bump Azure.Extensions.AspNetCore.Configuration.Secrets and 17 others HassanFad/chat-copilot#33

Open

dependabot bot mentioned this pull request

Bump Microsoft.Azure.Cosmos from 3.41.0 to 3.53.0 kmransom56/ai-research-platform#13

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

adityasa adityasa approved these changes

Maya-Painter Maya-Painter approved these changes

khdang Awaiting requested review from khdang khdang is a code owner

sboshra Awaiting requested review from sboshra sboshra is a code owner

neildsh Awaiting requested review from neildsh neildsh is a code owner

kirankumarkolli Awaiting requested review from kirankumarkolli kirankumarkolli is a code owner

ealsur Awaiting requested review from ealsur

FabianMeiswinkel Awaiting requested review from FabianMeiswinkel FabianMeiswinkel is a code owner

kirillg Awaiting requested review from kirillg kirillg is a code owner

Labels

auto-merge QUERY