Skip to content

Diagnostics: Adds DurationInMs to StoreResult #4462

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
May 9, 2024
Merged

Diagnostics: Adds DurationInMs to StoreResult #4462

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
291eba3
Add StoreResponseStatistics startTime to diagnostics
j82w Apr 29, 2024
81d70e3
Add latency in ms to make it easier to read.
Apr 30, 2024
ad0c1e4
Merge branch 'master' into origin/j82w/startTimeDiag
j82w Apr 30, 2024
bff7933
Converted to DurationInMs
May 1, 2024
1234a81
Merge branch 'origin/j82w/startTimeDiag' of https://github.com/Azure/…
May 1, 2024
d8ee98d
Remove start time
May 2, 2024
3eeb430
Merge branch 'master' into origin/j82w/startTimeDiag
j82w May 2, 2024
679e306
Update baseline file.
May 2, 2024
7bcd1c7
Merge branch 'master' into origin/j82w/startTimeDiag
j82w May 7, 2024
07fbe57
Merge branch 'master' into origin/j82w/startTimeDiag
ealsur May 9, 2024
a41d20f
Merge branch 'master' into origin/j82w/startTimeDiag
j82w May 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 17 additions & 3 deletions Microsoft.Azure.Cosmos/src/Tracing/TraceWriter.TraceJsonWriter.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -319,9 +319,23 @@ private void VisitStoreResponseStatistics(
{
this.jsonWriter.WriteObjectStart();

this.jsonWriter.WriteFieldName("StartTimeUTC");
this.WriteDateTimeStringValue(storeResponseStatistics.RequestStartTime);

this.jsonWriter.WriteFieldName("ResponseTimeUTC");
this.WriteDateTimeStringValue(storeResponseStatistics.RequestResponseTime);

this.jsonWriter.WriteFieldName("LatencyInMs");
if (storeResponseStatistics.RequestStartTime.HasValue)
{
TimeSpan latency = storeResponseStatistics.RequestResponseTime - storeResponseStatistics.RequestStartTime.Value;
this.jsonWriter.WriteNumber64Value(latency.TotalMilliseconds);
}
else
{
this.jsonWriter.WriteNullValue();
}

this.jsonWriter.WriteFieldName("ResourceType");
this.jsonWriter.WriteStringValue(storeResponseStatistics.RequestResourceType.ToString());

Expand Down Expand Up @@ -578,15 +592,15 @@ private void WriteStringValueOrNull(string value)
}
}

private void WriteDateTimeStringValue(DateTime value)
private void WriteDateTimeStringValue(DateTime? value)
{
if (value == null)
if (value == null || !value.HasValue)
{
this.jsonWriter.WriteNullValue();
}
else
{
this.jsonWriter.WriteStringValue(value.ToString("o", CultureInfo.InvariantCulture));
this.jsonWriter.WriteStringValue(value.Value.ToString("o", CultureInfo.InvariantCulture));
}
}

Expand Down
4 changes: 4 additions & 0 deletions ...osoft.Azure.Cosmos.Tests/BaselineTest/TestBaseline/TraceWriterBaselineTests.TraceData.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -316,7 +316,9 @@
],
"StoreResponseStatistics": [
{
"StartTimeUTC": "0001-01-01T00:00:00",
"ResponseTimeUTC": "9999-12-31T23:59:59.9999999",
"LatencyInMs": 315537897600000,
"ResourceType": "Document",
"OperationType": "Query",
"RequestSessionToken": "42",
Expand Down Expand Up @@ -512,7 +514,9 @@
],
"StoreResponseStatistics": [
{
"StartTimeUTC": null,
"ResponseTimeUTC": "0001-01-01T00:00:00",
"LatencyInMs": null,
"ResourceType": "Database",
"OperationType": "Create",
"LocationEndpoint": null,
Expand Down