Skip to content

Distributed Tracing: Adds configuration to disable network level tracing in sdk permanently #4333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Mar 7, 2024
Merged

Distributed Tracing: Adds configuration to disable network level tracing in sdk permanently #4333

merged 5 commits into from
Mar 7, 2024

Conversation

@sourabh1007
Copy link
Contributor

@sourabh1007 sourabh1007 commented Feb 29, 2024 •
edited
Loading

Description

It was decided that we are going to stop emitting network level traces to avoid confusion in customer.
Because it has information related to RNTBD calls which is an internal protocol, without much information documented publicly.

  1. Updated Sample Project also: to get it reflected here https://learn.microsoft.com/en-us/azure/cosmos-db/nosql/sdk-observability?tabs=dotnet
  2. Removed all the logic related to network level traces and corresponding tests.

Type of change

  • [] This change requires a documentation update

kirankumarkolli
kirankumarkolli reviewed Mar 4, 2024
View reviewed changes
kirankumarkolli
kirankumarkolli previously approved these changes Mar 4, 2024
View reviewed changes
@sourabh1007 sourabh1007 added the auto-merge Enables automation to merge PRs label Mar 5, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot enabled auto-merge (squash) March 5, 2024 01:32
philipthomas-MSFT
philipthomas-MSFT previously approved these changes Mar 5, 2024
View reviewed changes
FabianMeiswinkel
FabianMeiswinkel reviewed Mar 5, 2024
View reviewed changes
@microsoft-github-policy-service microsoft-github-policy-service bot merged commit deab135 into master Mar 7, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot deleted the users/sourabhjain/disablenetworklveltracing branch March 7, 2024 01:58
This was referenced Apr 11, 2024
Merged
Closed
Closed
@dependabot dependabot bot mentioned this pull request Jul 28, 2025
Closed
This was referenced Jul 28, 2025
Closed
Open
@dependabot dependabot bot mentioned this pull request Sep 22, 2025
Closed
@dependabot dependabot bot mentioned this pull request Oct 6, 2025
Open
@dependabot dependabot bot mentioned this pull request Nov 9, 2025
Closed
@dependabot dependabot bot mentioned this pull request Nov 17, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@FabianMeiswinkel FabianMeiswinkel FabianMeiswinkel left review comments

@kirankumarkolli kirankumarkolli kirankumarkolli approved these changes

@khdang khdang Awaiting requested review from khdang khdang is a code owner

@sboshra sboshra Awaiting requested review from sboshra sboshra is a code owner

@adityasa adityasa Awaiting requested review from adityasa adityasa is a code owner

@neildsh neildsh Awaiting requested review from neildsh neildsh is a code owner

@ealsur ealsur Awaiting requested review from ealsur

@kirillg kirillg Awaiting requested review from kirillg kirillg is a code owner

+1 more reviewer

@philipthomas-MSFT philipthomas-MSFT philipthomas-MSFT approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

auto-merge Enables automation to merge PRs

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@sourabh1007 @kirankumarkolli @FabianMeiswinkel @philipthomas-MSFT