Skip to content

Query: Fixes LINQ Translation of SqlNullLiteral Values #4260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

Maya-Painter
Copy link
Contributor

@Maya-Painter Maya-Painter commented Jan 17, 2024

Pull Request Template

Description

Addresses exception thrown when comparing DateTime and enum fields with custom converters to null.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Closing issues

closes #4193

adityasa
adityasa previously approved these changes Jan 17, 2024
Copy link
Contributor

@adityasa adityasa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

adityasa
adityasa previously approved these changes Jan 19, 2024
Copy link
Contributor

@adityasa adityasa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@leminh98
Copy link
Contributor

lgtm!

Copy link
Contributor

@leminh98 leminh98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@microsoft-github-policy-service microsoft-github-policy-service bot merged commit 4d9b7bd into master Jan 19, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot deleted the users/mayapainter/nullablelinqfix branch January 19, 2024 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-merge Enables automation to merge PRs QUERY
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Linq queries with nullable do not work when when custom json converter is applied
3 participants