Skip to content

Conversation

@kundadebdatta
Copy link
Member

@kundadebdatta kundadebdatta commented Mar 24, 2023

Pull Request Template

Description

Code changes to sync up msdata/master with latest v3 master and Cosmos.Direct v3.30.4.

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

ealsur and others added 30 commits October 27, 2022 16:43
#3517)

* Adding log lines

* More logs

* Debugging further

* Removing other builds

* And more debugging

* Wrong build parameters

* Wrong category

* Removing noise

* Fixing test

* Adding utils

* Adding test with client telemetry enabled

* Fixing leak in Client Telemetry Tests

* Reenabling test

* cpu monitor initialization

* Adding name details

* Undo another file
… BY queries with continuation (#3525)

* Revert performance regression caused by #1289

* Remove irrelevant comment

* Add a test for validating formatted filters for the target partition
…es (#3533)

* wip

* regenerated baseline

* add test

* fix test

Co-authored-by: Sourabh Jain <[email protected]>
* Remove starttime and id from diagnostics string

* Remove starttime and id from diagnostics string

* Update xml files for trace baseline tests

* Update xml files for trace baseline tests

* Update xml files for trace baseline tests

* Whitespaces update

* Changed starttime position based on code review

Co-authored-by: Matias Quaranta <[email protected]>
* Rough draft

* Some more changes

* Adding a new section

* Some more refinement

* Some changes 

Lets get the feedback

* Some MISC changes
* Bumped SDK version and changelog

* Added contracts file for 3.31.2
* Initial commit

* Update.

* Pull/Rebase

* Addressed comments.

* Build fix
…eGateway (#3556)

* Adding IdEncoding unit tests for ComputeGateway

* Reacting to code review feedback

* Updating md files
* Adding rid parsing

* Test

* Removing dead code

* Contract update
…ame is flowing to opentelemetry module (#3532)

* wip

* WIP

* Revert "WIP"

This reverts commit 71275de54b9e67fa54a37e79d450b9597e173934.

* Revert "wip"

This reverts commit 586fa9865cc3f40dabd7ef90fb3e0cf499a045bc.

* wip add containe and database info

* redesign how container and database name information flows into opne telemetry data

* test fix

* fix test

* fix tests

* fix typos

* baseline test fix

Co-authored-by: Sourabh Jain <[email protected]>
…ns (#3562)

* add flag in diagnostic options

* test fixes

* rename variable

* test fix

* add validation

* fix baseline

* test fix

Co-authored-by: Sourabh Jain <[email protected]>
…s in ServiceInterop (#3399)

* Don't default to BadRequestException in case of errors in ServiceInterop

* Incorporate code review feedback

* Fix build error

* fix up failing test
… OptimisticDirectExecution pipeline (#3510)

* Added tests to test different aspects of merge/split support with OptimisticDirectExecution pipeline. Tests check for gone exception handling, pipeline switching etc.

* Added gone exception simulation tests.

* Added new tests and improved test infra

* Removed ParalleContEvocation test. Fixed comments

* Removed CreateParallelCrossPartitionPipelineStateAsync() as it is not being used anymore

* Removed while loop in CreateDocumentContainerAsync()

* Fixed comments.

* Updated ExecuteGoneExceptionOnODEPipeline()

* Added type Assert for ExecuteGoneExceptionOnODEPipeline()

* Updated OptimisticDirectExecution pipeline abbreviation

* Updated TestBaseline folder with new xml
…on retry (#3555)

* Fixes to ReadThroughputAsync for databases with no provisioned throughput and null as request options

* fixed failure to ReadReplaceThroughputResponseTests

* Added Stream Method

* Ran UpdateContract.ps1

* Encryption implemtation

* Fixed spelling error

* Update Microsoft.Azure.Cosmos.Encryption/src/EncryptionDatabase.cs

Co-authored-by: Matias Quaranta <[email protected]>

* Variable name change

* Update Microsoft.Azure.Cosmos/src/Resource/Database/Database.cs

Co-authored-by: Matias Quaranta <[email protected]>

* Suggested Changes and fixes

* Removed manufactured ResponseMessage + nits

* Simplified PR

* nits

* nits

* initial changes TODO: Update tests

* updated tests

* nits'

* Ran UpdateContracts.ps1

* nits + requested changes

* Delete NuGet.Config

* Update Microsoft.Azure.Cosmos/src/HttpClient/CosmosHttpClientCore.cs

Co-authored-by: Matias Quaranta <[email protected]>

* Update Microsoft.Azure.Cosmos/src/HttpClient/HttpTimeoutPolicy.cs

Co-authored-by: Matias Quaranta <[email protected]>

* Update Microsoft.Azure.Cosmos/src/HttpClient/HttpTimeoutPolicy.cs

Co-authored-by: Matias Quaranta <[email protected]>

* Update Microsoft.Azure.Cosmos/src/HttpClient/HttpTimeoutPolicy.cs

Co-authored-by: Matias Quaranta <[email protected]>

* Use Cosmos Exception Factory, Simplified Tests

* removed unused code

* nits: removed unused code

* removed unused code

Co-authored-by: Matias Quaranta <[email protected]>
Co-authored-by: Nalu Tripician <[email protected]>
…ned elements (#3574)

* Do not maintain an independent count on QueryResponse that can go out of sync

* Add more test coverage for QueryResponse<T>.Count

* Output the correct count from CosmosElementSerializer when the input contains CosmosUndefined

* Add untyped tests for CosmosUndefined

* Remove commented code
Co-authored-by: Sourabh Jain <[email protected]>
* Trace: Fixes Tracing/diagnostics hour-times to 24Hours

* fixing baseline tests

Co-authored-by: Matias Quaranta <[email protected]>
* wip

* status code int and internal and client kind activity

* remove unused imports

* update baselines

* fix test

* fixed baseline tests

* fix tests

* update base tetss

Co-authored-by: Sourabh Jain <[email protected]>
* Add SqlAllScalarExpression to v3 DOM

* updated generated parser files

* Parsing for ALL

* Added tests for ALL and baselines

* Added more tests

* added new test, cleanup

* cleaning & fix typos

* fixed typo

* Added new baseline test file names to csproj file

* renamed AggregateAll to AggregateSubquery to accomodate FIRST and LAST later

* Added keywords for 'left' and 'right' and respective function calls

* fixed bug from last commit

* cleaning

* replace tabs with spaces

* cleaning
* Ensures that both Direct and Gateway connection modes are tested
* Validates that container read works with PermissionMode.Read (test was previously only validating that Delete was blocked - i.e. the negative case).
#3583)

* add tests for otel and custome listener

* clean up

* null pointer fix

* fix tets

* handle event generation also at operation level

* added documentation

* wip

* change event sourcename

* rename event Name

Co-authored-by: Sourabh Jain <[email protected]>
…le to be retried (#3607)

* data plane writes no longer failover on timeout

* removed duplication of test\
ealsur and others added 14 commits March 2, 2023 13:11
* Update Binskim and follow warnings

* Fixing task

* More version bumps

* binskim args

* Padding

* policheck

* postanalysis parameters

* analysis settings
… x86, Linux or in Optimistic Direct Execution (#3730)

* Minor clean up of OptimisticDirectExecutionQueryTests

* More minor cleanup in OptimisticDirectExecutionQueryTests

* Add emulator tests for the bypass query parsing scenario

* Handle PartitionKey.None while creating QueryIterator. This is a workaround for the PartitionKeyInternal.None not following its own contract

* Fix up to correctly handle PartitionKey.None using the CachedContainerQueryProperties

* Add more tests where PartitionKey.None maps to PartitionKey.Undefined

---------

Co-authored-by: Matias Quaranta <[email protected]>
* Add FIRST and LAST objects and update visitors

* add FIRST LAST evaluation and update offline engine visitors

* Add FIRST and LAST to parser

* update another visitor

* Fix typo

* fix typo

* added new tests and baselines

* cleaning

* cleaning

---------

Co-authored-by: neildsh <[email protected]>
Co-authored-by: Matias Quaranta <[email protected]>
…ub partitioned containers (#3109)

* 1st round of changes to support subpartitioning for ChangeFeed

* name change and moved a method to FeedRangePartitionKey

* support for prefix partition change feed and query including unit and emulator tests. need to verify using FeedRange with QueryIterator

* splitting out unit tests from emulator tests

* 1st round of changes to support subpartitioning for ChangeFeed

* name change and moved a method to FeedRangePartitionKey

* support for prefix partition change feed and query including unit and emulator tests. need to verify using FeedRange with QueryIterator

* splitting out unit tests from emulator tests

* moved logic to choose for prefix partition query and change feed

* additional conditional to check for MultiHash partitionkeydefinition kind

* removed unnecessary using

* cleanup

* unnecessary using

* removed PREVIEW from proj

* unit tests for ResolveFeedRangeBasedOnPrefixContainerAsync

* change access modifier

* since I changed to static, needed to fix tests

* dealing with some testing nits

* removed Console.Writeline

* slight change in test use containerProperties and partitionKeyDefinition

* big fix for resolve feedrange, changes to error behavior, added additional test coverage

* test changes

* ran updateContracts.ps1

* reverting to 3ad5309

* Ran Update Contracts

* ran updateContracts.ps1

* UpdateContracts.ps1

* updatecontracts

* removed bad check from test, removed changes from updatecontracts.ps1

* revert UpdateContracts changes

* Reverting to 756a123

* removed accidental change from changelog

* removed unwanted change from Directory.build.props

* added test clean up

* removed console.writelines

* updates to query test

* removed preview flag

* ran UpdateContrats.ps1

* no longer recread feedRange for queries unless using prefix pk

* simplified if statement

* fixed bug

---------

Co-authored-by: Nalu Tripician <[email protected]>
…3717)

* first draft

wip

fix test and logic

* resolve conflicts

* limit 2 mb

* ad callback

* fix tests

* code refactor

* cosmos json to newtosoft json

* clean up files

* fix logging to argumrnt based

* code refactor

* add null check
…m any account consistency (#3753)

- Localquorum override (i.e. strong) to allow from any account consistency
- Facilitates no-downtime downgrade of existing accounts (i.e. existing Strong/bounded accounts migration to Eventual)
* version bump

* contract

* changelog

* version bump

* Fixing changelog text

* Add another PR
…ersion (#3763)

* initial commit, Http version issues still needs to be resolved

* updateContracts + update Http Version

* updateded version in test

* update contracts

* requested changed

* changed name in comments to subpartitioning from multihash

* undid changes to TestLiteralSerialization.xml

* removed changes to non API.json files

* removed non XXXAPI.json file changes

* changed verbage on public comments

* changed error message to reflect verbage change
… APIs for Renew scenarios (#3775)

* Adding cases

* Tests
…dresses to Unhealthy when Connection Reset Event Occurs (#3768)

* Code changes to mark the transport uri to unhealthy for which a connection reset event occures through the connection state listener.

* Code changes to bump up the direct version.

* Code changes to clean up Gateway Address Cache.

* Code changes to fix pipeline build.

* Code changes to fix serilization test failures.

* Code changes to add force refresh to the gateway function callback delegate.
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good!

@kundadebdatta kundadebdatta changed the title Sync msdata/direct branch with latest v3 master and Cosmos.Direct v3.30.4 [Internal] Msdata/Direct: Refactors msdata/direct branch with latest v3 master and Cosmos.Direct v3.30.4 Mar 24, 2023
@kundadebdatta kundadebdatta self-assigned this Mar 24, 2023
@kirankumarkolli kirankumarkolli merged commit 94e811f into msdata/direct Mar 24, 2023
@kirankumarkolli kirankumarkolli deleted the users/kundadebdatta/sync_msdata_direct_with_master branch March 24, 2023 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.