Simplify building samples #3453
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deyaaeldeen
requested review from
MaryGao,
joheredi and
qiaozha
as code owners
deyaaeldeen
force-pushed
the
build-samples-edit
branch
from
3cc4f5e to
14b9d74
Compare
MaryGao
requested changes
Aug 20, 2025
There was a problem hiding this comment.
Let me understand more background for this change first and confirm some details here: Azure/azure-sdk-for-js#35601 (comment).
deyaaeldeen
added a commit
to Azure/azure-sdk-for-js
that referenced
this pull request
Aug 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Publishing samples shouldn't be part of building samples. Publishing should occur only after the package has been released.