Skip to content

Pnpm migration #3366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 23 commits into
base: main
Choose a base branch
from
Draft

Pnpm migration #3366

wants to merge 23 commits into from

Conversation

jeremymeng
Copy link
Member

No description provided.

@jeremymeng jeremymeng marked this pull request as draft July 7, 2025 22:01
@jeremymeng
Copy link
Member Author

Here's what it looks like for migrating to pnpm

@qiaozha
Copy link
Member

qiaozha commented Jul 9, 2025

@jeremymeng could you update the ci.yaml/release.yaml? I think those have references to the rush scripts.

@jeremymeng
Copy link
Member Author

@jeremymeng could you update the ci.yaml/release.yaml? I think those have references to the rush scripts.

@qiaozha I have updated files under .scripts and no longer see any references of "rush". I don't know for sure though whether replacing them with pnpm works as expected.

jeremymeng
jeremymeng commented Jul 10, 2025
View reviewed changes
jeremymeng
jeremymeng commented Jul 10, 2025
View reviewed changes
packages/autorest.typescript/test/rlcIntegration/lroRest.spec.ts
assert.fail("Should be aborted by stopPolling");
} catch (e) {
assert.equal(e.message, "The operation was aborted.");
assert.equal(e.name, "AbortError");
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The error message has been changed in latest core.

@qiaozha qiaozha added the P1 priority 1 label Aug 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joheredi joheredi Awaiting requested review from joheredi joheredi is a code owner

@qiaozha qiaozha Awaiting requested review from qiaozha qiaozha is a code owner

@MaryGao MaryGao Awaiting requested review from MaryGao MaryGao is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@MaryGao MaryGao

@v-jiaodi v-jiaodi

Labels

P1 priority 1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jeremymeng @qiaozha @MaryGao @v-jiaodi