Skip to content

Add case for apiVersion header/path/query #3303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 11 commits into
base: main
Choose a base branch
from
Draft

Add case for apiVersion header/path/query #3303

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
75f2f33
add case for apiVersion header/path/query
v-jiaodi Jun 18, 2025
e8e7069
Merge branch 'main' of https://github.com/Azure/autorest.typescript i…
v-jiaodi Jun 18, 2025
777febb
Merge branch 'main' of https://github.com/Azure/autorest.typescript i…
v-jiaodi Jun 24, 2025
6e853f1
fix
v-jiaodi Jun 24, 2025
4a83607
format
v-jiaodi Jun 24, 2025
49f0825
Merge branch 'main' of https://github.com/Azure/autorest.typescript i…
v-jiaodi Jun 26, 2025
997f893
revert change
v-jiaodi Jun 26, 2025
6909112
Merge branch 'main' of https://github.com/Azure/autorest.typescript i…
v-jiaodi Jun 26, 2025
2bcecc0
Merge branch 'main' into add-case6181
v-jiaodi Jun 26, 2025
e7a14b1
Merge branch 'main' of https://github.com/Azure/autorest.typescript i…
v-jiaodi Jun 27, 2025
47030c0
Merge branch 'add-case6181' of https://github.com/v-jiaodi/autorest.t…
v-jiaodi Jun 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions packages/typespec-ts/src/modular/buildClientContext.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -195,9 +195,8 @@ export function buildClientContext(
: [];
const apiVersionInEndpoint =
templateArguments && templateArguments.find((p) => p.isApiVersionParam);
const parameterName = getClientParameterName(apiVersionParam);
if (!apiVersionInEndpoint && apiVersionParam.clientDefaultValue) {
apiVersionPolicyStatement += `const ${parameterName} = options.${parameterName} ?? "${apiVersionParam.clientDefaultValue}";`;
apiVersionPolicyStatement += `const apiVersion = options.apiVersion ?? "${apiVersionParam.clientDefaultValue}";`;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding a version definition can make the code work properly.

}

if (apiVersionParam.kind === "method") {
Expand All @@ -211,7 +210,7 @@ export function buildClientContext(
if (!url.searchParams.get("api-version")) {
req.url = \`\${req.url}\${
Array.from(url.searchParams.keys()).length > 0 ? "&" : "?"
}api-version=\${${parameterName}}\`;
}api-version=\${${getClientParameterName(apiVersionParam)}}\`;
}

return next(req);
Expand Down