Populate feature flag telemetry metadata #47
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds telemetry metadata population functionality to feature flags in Azure App Configuration. It ensures that when feature flags have telemetry enabled, they are populated with reference URLs and ETags for tracking purposes.
- Adds new functions
generateFeatureFlagReferenceandpopulateTelemetryMetadatato populate telemetry metadata - Integrates telemetry metadata population into the
loadFeatureFlagsworkflow - Adds comprehensive test coverage for various telemetry scenarios including flags with/without telemetry, existing metadata preservation, and URL generation edge cases
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| azureappconfiguration.go | Adds telemetry metadata population logic and URL generation functions |
| azureappconfiguration_test.go | Adds comprehensive test coverage for telemetry metadata functionality |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| // Set the new metadata | ||
| if setting.ETag != nil { | ||
| metadata[eTagKey] = *setting.ETag | ||
| } |
There was a problem hiding this comment.
The eTagKey constant is not defined in the visible code. This should be defined as a constant alongside other metadata keys to maintain consistency and avoid magic strings.
Copilot uses AI. Check for mistakes.
| if setting.ETag != nil { | ||
| metadata[eTagKey] = *setting.ETag | ||
| } | ||
| metadata[featureFlagReferenceKey] = generateFeatureFlagReference(setting, endpoint) |
There was a problem hiding this comment.
The featureFlagReferenceKey constant is not defined in the visible code. This should be defined as a constant alongside other metadata keys to maintain consistency and avoid magic strings.
Copilot uses AI. Check for mistakes.
No description provided.