Shorten the default timeout of individual call to backend #620
Conversation
There was a problem hiding this comment.
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (1)
src/Microsoft.Extensions.Configuration.AzureAppConfiguration/AzureAppConfigurationProvider.cs:1136
- Ensure that the new timeout behavior introduced by checking for TaskCanceledException with an inner TimeoutException is covered by tests.
TaskCanceledException tce = ex.InnerExceptions?.LastOrDefault(e => e is TaskCanceledException) as TaskCanceledException;
RichardChen820
force-pushed
the
user/junbchen/shorten_timeout_of_each_call
branch
from
71a346e to
4e7f8b0
Compare
|
@RichardChen820 why don't merge this? @amerjusupovic @jimmyca15 is there a plan to release 8.1.1? Should this be included? |
|
Discussed offline. Won't block the 8.1.1 train. This change will be included in the next release. |
amerjusupovic
force-pushed
the
user/junbchen/shorten_timeout_of_each_call
branch
5 times, most recently
from
2dd4ed8 to
b89c6d0
Compare
…etProvider into user/junbchen/shorten_timeout_of_each_call
amerjusupovic
force-pushed
the
user/junbchen/shorten_timeout_of_each_call
branch
from
b89c6d0 to
8030c60
Compare
|
[like] Richard Chen reacted to your message:
…________________________________
From: Amer Jusupovic ***@***.***>
Sent: Tuesday, March 18, 2025 7:50:08 PM
To: Azure/AppConfiguration-DotnetProvider ***@***.***>
Cc: Richard Chen ***@***.***>; Mention ***@***.***>
Subject: Re: [Azure/AppConfiguration-DotnetProvider] Shorten the default timeout of individual call to backend (PR #620)
Merged #620<#620> into main.
—
Reply to this email directly, view it on GitHub<#620 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AXUUZHMNHLJRHUHNFWPAUTD2VB2HBAVCNFSM6AAAAABXBP6KLCVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJWHA2DKMZQGU2TINQ>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
|
Why did this PR go in with every single line of AzureAppConfigurationOptions changed? |
It's my fault, I couldn't find a way to fix it, but I should have just redone the PR. I'll revert this and put up a new one. |
…)" This reverts commit 87f0f85.
|
@amerjusupovic Right, we shouldn't merge the PR if it has something malformatted like that, but fixing it would be on the author's plate. |
…)" This reverts commit 87f0f85.
|
@amerjusupovic I guess the unexpected change comes from rebase - conflict resolution - force commit? I ensure I didn't have those changes in my PR. |
Yes @RichardChen820 these issues were all just as a result of inconsistent line endings in the repo and conflict resolution when I tried to push them, sorry about that. I'm resending your changes with just a slight change here based on feedback from @jimmyca15: #657 |
Shorten the default timeout of individual call to backend