Skip to content

Ibrahimmalhas patch web push notification bug fixes #174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Ibrahimmalhas patch web push notification bug fixes #174

wants to merge 4 commits into from

Conversation

@ibrahimmalhas
Copy link

@ibrahimmalhas ibrahimmalhas commented Oct 5, 2023

Purpose

  • ...
    The main branch code for web-notification has some errors when running the app. I just added the fixes for some typo error on the code.

Does this introduce a breaking change?

[X] Yes
[ ] No

Pull Request Type

What kind of change does this Pull Request introduce?

[X] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

How to Test

  • Get the code
    Run the "Web-Push-notification-sample" normally

Changes involve fix:

  1. Azure function App code
  2. axios and fetch dependencies
  3. fix the body data for "oneSignalRegistrationToken" function
git clone [repo-address]
cd [repo-name]
git checkout [branch-name]
npm install
  • Test the code

What to Check

Verify that the following are valid

  • ...

Other Information

@ibrahimmalhas
Update webpack.config.js
1f318d3 
added oneSignalRegistrationToken, since there was a missing key for the API body
@ibrahimmalhas
Update index.js
c45b277 
adding fetch dependancy
@ibrahimmalhas
Update package.json
b755e79 
adding missing fetch depenecy
@ibrahimmalhas
Update OneSignalRegistrationTokens.js
e668fca 
fixing type error 
getOneSignalRegistrationInfo & setOneSignalRegistrationInfo

instead of 

getOneSignalRegistrationToken & setOneSignalRegistrationToken
@ibrahimmalhas
Copy link
Author

ibrahimmalhas commented Oct 5, 2023

@microsoft-github-policy-service agree company="Microsoft"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@ibrahimmalhas