APIGOV-31178 - do not stop request queue within request queue #974
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcollins-axway
requested review from
alrosca,
dfeldick,
dgghinea,
sbolosan and
vivekschauhan
as code owners
vivekschauhan
approved these changes
Sep 22, 2025
sbolosan
approved these changes
Sep 22, 2025
dgghinea
approved these changes
Sep 23, 2025
alrosca
approved these changes
Sep 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the stopping of the request queue from the main loop of the request queue. An outside process will cancel the context or stop the request queue directly.
7 out of 1000 test runs of the stream package would hit a panic error because the client and the request queue process both tried to close the receive channel.