-
Notifications
You must be signed in to change notification settings - Fork 38
Add new string assertions: BeParsableInto<T>
and NotBeParsableInto<T>
#185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ITaluone
commented
Jun 13, 2025
Pull Request Test Coverage Report for Build 15660017692Details
💛 - Coveralls |
ITaluone
commented
Jun 13, 2025
Tests/AwesomeAssertions.Specs/Primitives/StringAssertionSpecs.Parsable.cs
Outdated
Show resolved
Hide resolved
ad3cbb6
to
2d914de
Compare
ITaluone
commented
Jun 13, 2025
Tests/AwesomeAssertions.Specs/Primitives/StringAssertionSpecs.Parsable.cs
Outdated
Show resolved
Hide resolved
cbersch
requested changes
Jun 13, 2025
Tests/AwesomeAssertions.Specs/Primitives/StringAssertionSpecs.Parsable.cs
Outdated
Show resolved
Hide resolved
Tests/AwesomeAssertions.Specs/Primitives/StringAssertionSpecs.Parsable.cs
Outdated
Show resolved
Hide resolved
Tests/AwesomeAssertions.Specs/Primitives/StringAssertionSpecs.Parsable.cs
Outdated
Show resolved
Hide resolved
Tests/AwesomeAssertions.Specs/Primitives/StringAssertionSpecs.Parsable.cs
Outdated
Show resolved
Hide resolved
Tests/AwesomeAssertions.Specs/Primitives/StringAssertionSpecs.Parsable.cs
Outdated
Show resolved
Hide resolved
cbersch
requested changes
Jun 13, 2025
Tests/AwesomeAssertions.Specs/Primitives/StringAssertionSpecs.Parsable.cs
Outdated
Show resolved
Hide resolved
Tests/AwesomeAssertions.Specs/Primitives/StringAssertionSpecs.Parsable.cs
Outdated
Show resolved
Hide resolved
Tests/AwesomeAssertions.Specs/Primitives/StringAssertionSpecs.Parsable.cs
Outdated
Show resolved
Hide resolved
Tests/AwesomeAssertions.Specs/Primitives/StringAssertionSpecs.Parsable.cs
Outdated
Show resolved
Hide resolved
Tests/AwesomeAssertions.Specs/Primitives/StringAssertionSpecs.Parsable.cs
Outdated
Show resolved
Hide resolved
cbersch
approved these changes
Jun 14, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That looks good! Thank you
ScarletKuro
approved these changes
Jun 14, 2025
IT-VBFK
reviewed
Jun 15, 2025
Tests/AwesomeAssertions.Specs/Primitives/StringAssertionSpecs.Parsable.cs
Outdated
Show resolved
Hide resolved
Tests/AwesomeAssertions.Specs/Primitives/StringAssertionSpecs.Parsable.cs
Outdated
Show resolved
Hide resolved
Tests/AwesomeAssertions.Specs/Primitives/StringAssertionSpecs.Parsable.cs
Outdated
Show resolved
Hide resolved
Tests/AwesomeAssertions.Specs/Primitives/StringAssertionSpecs.Parsable.cs
Outdated
Show resolved
Hide resolved
IT-VBFK
reviewed
Jun 15, 2025
Tests/AwesomeAssertions.Specs/Primitives/StringAssertionSpecs.Parsable.cs
Outdated
Show resolved
Hide resolved
This was referenced Aug 5, 2025
This was referenced Aug 18, 2025
Merged
This was referenced Aug 25, 2025
This was referenced Sep 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #168
IMPORTANT
./build.sh --target spellcheck
or.\build.ps1 --target spellcheck
before pushing and check the good outcome