-
Notifications
You must be signed in to change notification settings - Fork 20
make dialog can be stack popup #86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Coloryr
commented
Mar 14, 2025
I appreciate this work, the reason I haven't done it myself is because I don't know how it should be designed as a feature. I need to spend a little more time thinking about this implementation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall works fine, but i think there is need for proper handling of disabling of multiple dialogs. E.g. if i open 2 dialogs, i should be able to interact only with a top one (second one should be non interactable).
Close command also always closes the top dialog (but if other dialogs will be non interactable, then this is not a problem).
And probably we should move multidialog logic to separate control (since currently at least IsOpen would works weirdly), what do you think? Btw, after looking at this PR i kinda want to rewrite dialoghost almost from scratch, but i think what i don't have enough time
e.NameScope.Find<Rectangle>(ContentCoverName)?.AddDisposableHandler(PointerReleasedEvent, ContentCoverGrid_OnPointerReleased) ?? EmptyDisposable.Instance | ||
}; | ||
base.OnApplyTemplate(e); | ||
} | ||
|
||
private class DisposeList : IDisposable { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably it should be moved into host itself. We actually doesn't want to control it from the host side
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, that is better
CurrentSession should be IReadOnlyList.
Is it done intentionally, or you address this in a future, or i should do it myself? |
|