Rewrite leak tests without dotMemory Unit #20095
Open
+465
−456
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MrJul
added
enhancement
area-infrastructure
|
You can test this PR using the following package version. |
MrJul
force-pushed
the
feature/rewrite-leak-tests
branch
from
8276247 to
7cfd946
Compare
|
You can test this PR using the following package version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the pull request do?
This PR rewrites all tests in the
LeakTestsproject to avoid dotMemory Unit.dotMemory Unit doesn't work correctly on modern .NET runtimes (see #20004).
Plus, the tests randomly fail on CI, which is quite annoying.
All tests are now using
WeakReferenceinstead.While the changes are relatively straightforward, the
Transition_On_StyledProperty_Is_Freedis the only test that checked for an instance of a type not directly accessible (TransitionInstance) anywhere. A few internal members have been added to get a hold of that instance.ControlTestsare only executed in release mode (somehow some instances are temporarily kept rooted in debug mode). This isn't worse than before, where tests needed to be started through dotMemory Unit anyway and most still failed in debug mode.Fixed issues