Fix TextLineIImpl.GetTextBounds for clustered trailing zero width characters #19208
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gillibald
added
customer-priority
Member
|
What was the broken behavior before the PR? |
MrJul
approved these changes
Jul 7, 2025
Contributor
Author
| coveredLength was negative here and resulted in an infinite loop. There should be some guard to prevent this. |
|
You can test this PR using the following package version. |
Gillibald
added a commit
to Gillibald/Avalonia
that referenced
this pull request
Jul 14, 2025
…racters (AvaloniaUI#19208) * Make sure we only apply the cluster offset if we are inside the current cluster * Better naming * Guard coveredLength against invalid values --------- Co-authored-by: Max Katz <[email protected]>
MrJul
pushed a commit
that referenced
this pull request
Jul 14, 2025
…racters (#19208) (#19251) * Make sure we only apply the cluster offset if we are inside the current cluster * Better naming * Guard coveredLength against invalid values --------- Co-authored-by: Max Katz <[email protected]>
MrJul
added
backported-11.3.x
and removed
backport-candidate-11.3.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the pull request do?
This PR ensures that TextLineImpl.GetTextBounds properly handles zero width trailing characters.
What is the current behavior?
What is the updated/expected behavior with this PR?
How was the solution implemented (if it's not obvious)?
Checklist
Breaking changes
Obsoletions / Deprecations
Fixed issues