Fix Windows Alt codes #18624
Merged
Fix Windows Alt codes #18624
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MrJul
added
bug
os-windows
backport-candidate-11.2.x
3 tasks
|
You can test this PR using the following package version. |
Gillibald
approved these changes
Apr 10, 2025
MrJul
added a commit
that referenced
this pull request
Apr 11, 2025
MrJul
added
backported-11.2.x
and removed
backport-candidate-11.2.x
MrJul
added a commit
that referenced
this pull request
Apr 12, 2025
MrJul
added
backported-11.3.x
and removed
backport-candidate-11.3.x
This was referenced Apr 14, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the pull request do?
This PR fixes Alt codes (alt+numpad) on Windows.
This is an alternative to #18612.
What is the current behavior?
Using Alt codes produce the wrong characters.
See #15938 for more details.
What is the updated/expected behavior with this PR?
Alt codes are correctly handled and produce the expected characters.
How was the solution implemented (if it's not obvious)?
The issue was introduced in #12549, which added the
KeySymbolproperty.The
KeySymbolis computed using Win32 ToUnicodeEx, which can mess up the keyboard state (even though we're explicitly passing a flag to avoid that...)WM_SYSKEYDOWN/UPnever produces any key symbol anyways, so this PR avoids callingToUnicodeExin this case.Fixed issues