-
Notifications
You must be signed in to change notification settings - Fork 101
Expose RippleEffect.RaiseRipple and RaiseRippleAbsoluteCoord function #453
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Why do you want to merge to |
i remember that previous PR did same thing |
I also have the same question about the previous PR. :) If there is no specific reason we can target master |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine
Details
This will make
RippleEffectusable as a element that can guide user which things are they looking for, or make it raisable by keyboard or any source.Exposed API
RippleEffect.RaiseRippleRaise a ripple element at the coordinate. By default it will raise at center point of the bound ofRippleEffectcontroldouble nX = 0.5normalised X coordinate, valid range: [0.0 - 1.0]double nY = 0.5normalised Y coordinate, valid range: [0.0 - 1.0]RippleEffect.RaiseRippleAbsoluteCoordRaise a ripple element at the non-normalised coordinates. (acquired by Expose RippleEffect.RaiseRipple and RaiseRippleAbsoluteCoord function #453 (comment))double xX coordinate, should be in bounds of theRippleEffectdouble yY coordinate, should be in bounds of theRippleEffectContext
#450 (comment)
#450 (comment)
Changes
AutomationAssistclass to contains examples for advanced automation usages of the theming library and AvaloniaUI framework, the implementation should be easy to understand, also they cannot be added directly in library but should be "attachable".IsClickedattached property to theAutomationAssistof theMaterial.Avalonia.Demo, and add button clicked observer to theAutomationAssist, this desicion have been made in PR Add HyperlinkButton theming support #450 (review) which we should make it as a usage example rather than integrating it to the libraryFloatingButtoncontrol template, which theRippleEffectdidnt have name to satisfy predication of functionRaiseRipplePrivateRippleEffectand expose APIRaiseRippleandRaiseRippleAbsoluteCoord. This API usage will be demonstrated in the demo project.