Skip to content

Conversation

@appleneko2001
Copy link
Collaborator

@appleneko2001 appleneko2001 commented May 2, 2025

Details

This will make RippleEffect usable as a element that can guide user which things are they looking for, or make it raisable by keyboard or any source.

Exposed API

  • RippleEffect.RaiseRipple Raise a ripple element at the coordinate. By default it will raise at center point of the bound of RippleEffect control
    • parameter double nX = 0.5 normalised X coordinate, valid range: [0.0 - 1.0]
    • parameter double nY = 0.5 normalised Y coordinate, valid range: [0.0 - 1.0]
  • RippleEffect.RaiseRippleAbsoluteCoord Raise a ripple element at the non-normalised coordinates. (acquired by Expose RippleEffect.RaiseRipple and RaiseRippleAbsoluteCoord function #453 (comment))
    • parameter double x X coordinate, should be in bounds of the RippleEffect
    • parameter double y Y coordinate, should be in bounds of the RippleEffect

Context

#450 (comment)
#450 (comment)

Changes

  • Create a AutomationAssist class to contains examples for advanced automation usages of the theming library and AvaloniaUI framework, the implementation should be easy to understand, also they cannot be added directly in library but should be "attachable".
  • Move IsClicked attached property to the AutomationAssist of the Material.Avalonia.Demo, and add button clicked observer to the AutomationAssist , this desicion have been made in PR Add HyperlinkButton theming support #450 (review) which we should make it as a usage example rather than integrating it to the library
  • Correcting FloatingButton control template, which the RippleEffect didnt have name to satisfy predication of function RaiseRipplePrivate
  • Refactor RippleEffect and expose API RaiseRipple and RaiseRippleAbsoluteCoord. This API usage will be demonstrated in the demo project.

@appleneko2001 appleneko2001 changed the base branch from master to ripple-raise-api-expose May 2, 2025 08:04
@appleneko2001 appleneko2001 requested a review from SKProCH May 2, 2025 08:04
@SKProCH
Copy link
Collaborator

SKProCH commented May 2, 2025

Why do you want to merge to ripple-raise-api-expose branch instead of master branch?

@appleneko2001
Copy link
Collaborator Author

Why do you want to merge to ripple-raise-api-expose branch instead of master branch?

i remember that previous PR did same thing

@SKProCH
Copy link
Collaborator

SKProCH commented May 3, 2025

Why do you want to merge to ripple-raise-api-expose branch instead of master branch?

i remember that previous PR did same thing

I also have the same question about the previous PR. :) If there is no specific reason we can target master

@SKProCH SKProCH changed the base branch from ripple-raise-api-expose to master May 3, 2025 20:19
@appleneko2001 appleneko2001 requested a review from SKProCH May 4, 2025 10:15
@appleneko2001 appleneko2001 changed the title Expose RippleEffect.RaiseRipple function Expose RippleEffect.RaiseRipple and RaiseRippleAbsoluteCoord function May 4, 2025
@appleneko2001 appleneko2001 added the enhancement New feature or request label May 4, 2025
Copy link
Collaborator

@SKProCH SKProCH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants