MSD: Only show if we have records.

[StevenDufresne]

See context: p1763342512081109-slack-C08JZTRS6NA.

Proposed Changes

On a new site with no logs we show an upsell banner that suggest users upgrade to remove the "20 free" activity logs restriction. It feels a bit premature to upsell on a feature that user's partially have but haven't seen yet.

In my opinion, it make sense to only show the upsell banner after a log(s) exists. While we want users to upgrade we want to reduce the number of "gates" we show the user.

Screenshot

Before	After

Once records exist they'll get:

Why are these changes being made?

Testing Instructions

• On a new free site, check your activity logs, expect to not see a banner.
• Make a site updates (change the name)
• Return to the activity log section, expect to see the banner

Pre-merge Checklist

• Has the general commit checklist been followed? (PCYsg-hS-p2)
• Have you written new tests for your changes?
• Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
• Have you checked for TypeScript, React or other console errors?
• Have you tested accessibility for your changes? Ensure the feature remains usable with various user agents (e.g., browsers), interfaces (e.g., keyboard navigation), and assistive technologies (e.g., screen readers) (PCYsg-S3g-p2).
• Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
• Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
• For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

[github-actions]

Calypso Live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:build-162167

Jetpack Cloud live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:build-162167&env=jetpack

Automattic for Agencies live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:build-162167&env=a8c-for-agencies

[arthur791004]

The changes look good to me but I'm not sure whether we want to keep upsell even if there is no record.

[StevenDufresne]

The changes look good to me but I'm not sure whether we want to keep upsell even if there is no record.

Thanks for the code review. I'll follow up with stakeholders to make sure we want this changes.

@arasaraskocaoglan @lucasmendes-design Thoughts?