Fetch Gridicons via SwiftPM #1714
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
| App Name | Simplenote Prototype Build | |
| Build Number | 1289 | |
| Version | PR #1714 | |
| Bundle ID | com.codality.NotationalFlow.Alpha | |
| Commit | 40f8106 | |
| Installation URL | 0ur5oikj8f55o |
mokagio
added
the
tooling
AliSoftware
approved these changes
Jun 16, 2025
mokagio
deleted the
ainfra-445-migrate-simplenote-ios-pods-to-swiftpm-gridicons
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix
See https://linear.app/a8c/issue/AINFRA-445 and previous PRs like #1713 .
Test
Run the app on Simulator or device and check either the magic link flow or the privacy screen as they are the only ones using Gridicons. Notice the icons are still there
Note
UI tests failing because of #1717
Review
Only one developer required to review these changes, but anyone can perform the review.
Release
These changes do not require release notes.