-
Notifications
You must be signed in to change notification settings - Fork 580
Upgrade everything #3183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Upgrade everything #3183
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s.binding('http_parser')
…o upgrade webpack to 5.0+
…at should be working but aren't
Closed
roundhill
approved these changes
May 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we're at the point to land this! I've tested it a bunch in local dev electron and on web browsers.
Windows/Linux/Mac builds are also tested as well 🥳
This was referenced May 9, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes and problems so far
lts/hydrogen
(v18.19.1
)husky
with normal git hook and a line innpm prepare
misty
withconcurrently
andwait-on
in theMakefile
file-loader
replaced with asset modulesnpm audit
now yieldsfound 0 vulnerabilities
😎Monaco editor can't be upgraded past 0.45.0 due to platform detection issue ([Bug] Platform is not always well detected microsoft/monaco-editor#4378) - this will be fixed in 0.48.0Update: Bumped to 0.48.0 to circumvent thisFollow-up work
simperium
(e.g.uuid
)References
Test
Setup: Decrypt the config using
openssl aes-256-cbc -md md5 -d -in ./resources/secrets/config.json.enc -out ./config.json -k [key from the secret store]
To test: basically everything 😭
npm run test
npm run dev
make build
etc