Skip to content

Conversation

codebykat
Copy link
Contributor

@codebykat codebykat commented Mar 20, 2024

Changes and problems so far

  • node version bumped to lts/hydrogen (v18.19.1)
  • replaced husky with normal git hook and a line in npm prepare
  • replaced misty with concurrently and wait-on in the Makefile
  • e2e tests disabled; Spectron is deprecated
  • Webpack 4->5 migration has significant configuration differences (polyfills especially)
  • Webpack file-loader replaced with asset modules
  • Fixed up linting (eslint / stylelint / prettier), for now ignoring changes that prettier and the linter want to make, to avoid making this PR hard to review
  • npm audit now yields found 0 vulnerabilities 😎
  • Fixed: Our hack to disable default keybindings stopped working because there's now an official way to disable keybindings
  • Monaco editor can't be upgraded past 0.45.0 due to platform detection issue ([Bug] Platform is not always well detected microsoft/monaco-editor#4378) - this will be fixed in 0.48.0 Update: Bumped to 0.48.0 to circumvent this
  • Fixed: new note not focusing editor (actually editor not focusing on load) - this is an issue with react-monaco-editor above version 0.50.1
  • Replaced Enzyme with react-testing-library (ref: Enzyme is dead)
  • React to version 17
  • MaterialUI v4 -> v5
  • CircleCI builds... code signing
  • Fix Monaco completion provider (for internal note links)
  • Removed unwanted items from the Monaco context menu without CSS hacks! 🤩

Follow-up work

  • possibly need to do a PR to upgrade vulnerable packages in simperium (e.g. uuid)

References

Test

Setup: Decrypt the config using openssl aes-256-cbc -md md5 -d -in ./resources/secrets/config.json.enc -out ./config.json -k [key from the secret store]

To test: basically everything 😭

  • npm run test
  • npm run dev
  • make build etc

@codebykat codebykat marked this pull request as ready for review May 8, 2024 07:25
@codebykat codebykat self-assigned this May 8, 2024
@codebykat codebykat changed the title WIP: Upgrade everything Upgrade everything May 8, 2024
@codebykat codebykat mentioned this pull request May 8, 2024
@codebykat codebykat requested a review from roundhill May 9, 2024 17:09
Copy link
Contributor

@roundhill roundhill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we're at the point to land this! I've tested it a bunch in local dev electron and on web browsers.

Windows/Linux/Mac builds are also tested as well 🥳

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants