-
Notifications
You must be signed in to change notification settings - Fork 58
feat(ia): settings additional brands #3462
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 29 commits
Commits
Show all changes
42 commits
Select commit
Hold shift + click to select a range
3d75573
feat: boilerplate
jaredrethman c599556
feat: boilerplate
jaredrethman 8dbb00f
feat: conditionally add `additional-brands` to local data
jaredrethman d531f93
feat: add jsdoc block to appease TS
jaredrethman 5b473bb
feat: add wildcard `*` active menu item matching
jaredrethman d44cc90
feat: add request queuing and processing
jaredrethman e6a7c5a
refactor: label and return jsdoc type
jaredrethman b1d1890
feat: brand component, types
jaredrethman c522bcd
feat: working additional brands
jaredrethman abb5f5c
fix: ci / eslint, typescript
jaredrethman 5291d1a
revert: request queing and removed early exit for `isFetching`
jaredrethman 864ee40
feat: add conditional prop to init fetch logic
jaredrethman 4b2782b
fix: eslint / ci
jaredrethman 3f07212
refactor: add requests ref to track hook requests
jaredrethman a64031f
Merge remote-tracking branch 'origin/feat/ia-settings-display-setting…
jaredrethman 9368d88
Merge remote-tracking branch 'origin/feat/ia-settings-display-setting…
jaredrethman 18458a3
Merge remote-tracking branch 'origin/epic/ia' into feat/ia-settings-a…
jaredrethman 4c86281
refactor: tweak loading title
jaredrethman 1abb3a9
feat: add logo fetching logic & ui
jaredrethman 3e30fef
feat: remove query args from cache key
jaredrethman 7da9155
refactor: manage cache manually, code consolidation
jaredrethman 945bf55
feat: add cache management
jaredrethman 17c9ded
refactor: remove unnecessary properties from `Brand` type
jaredrethman dcdfc27
Merge remote-tracking branch 'origin/epic/ia' into feat/ia-settings-a…
jaredrethman 971ec29
fix: ci / typescript, eslint
jaredrethman d6a9a17
Merge remote-tracking branch 'origin/feat/manual-cache-logic' into fe…
jaredrethman d91cde0
Merge remote-tracking branch 'origin/epic/ia' into feat/ia-settings-a…
jaredrethman 7c51d97
refactor: component name changes + doc comments
jaredrethman e4715a7
refactor: replace property drill with const
jaredrethman 0c754a2
feat: conditionally load additional-brands component
jaredrethman c256a23
refactor: pr feedback - update conditional
jaredrethman 63ede23
refactor: pr feedback - placeholder
jaredrethman 78c3e3c
refactor: move tab path to constant
jaredrethman cfeac38
fix: pr feedback - cancel button destination
jaredrethman c4d7d11
revert: name placeholder
jaredrethman 3bd7e88
refactor: pr feedback - move slug to paceholder
jaredrethman 75833a3
refactor: pr feedback - name placeholder
jaredrethman c10e4d7
feat: add error message to upsert
jaredrethman 46b0018
fix: force add `slug` to cache
jaredrethman d95e89d
refactor: pr feedback - use entire `result`
jaredrethman 920a27a
feat: pr feedback - `resetError` on location change
jaredrethman a9705bc
Merge remote-tracking branch 'origin/epic/ia' into feat/ia-settings-a…
jaredrethman File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.