NativeArray<float> , burst and Jobs #4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Worth checking as it's the first time I delve into native plugins :
in NativeFastNoise2.cs :
my use of void* instead of float* for noiseOut , xPosArray... , mimax necessary because unity's NativeArrayUnsafeUtility.GetUnsafePtr(NativeArray) returns void*
my use of address of a float2 &minMax
inspired from the indexer in https://github.com/Unity-Technologies/Unity.Mathematics/blob/master/src/Unity.Mathematics/float2.gen.cs
in NativeFastNoise2Test.cs / FastNoiseJobParallelForBatch
-the threadsafety thing, but I think it's fine :
And btw, congrats and thanks for fastnoise2 and it's node tool, it's awesome !