Skip to content

Conversation

@ALameLlama
Copy link
Member

📑 Description

While bashls doesn't officially support zsh, the syntax is almost the same and will get you most of the way there to make dealing with zsh files much better.

@github-actions
Copy link

github-actions bot commented Apr 15, 2025

Review Checklist

Does this PR follow the [Contribution Guidelines](development guidelines)? Following is a partial checklist:

Proper conventional commit scoping:

  • If you are adding a new plugin, the scope would be the name of the category it is being added into. ex. feat(utility): added noice.nvim plugin

  • If you are modifying a pre-existing plugin or pack, the scope would be the name of the plugin folder. ex. fix(noice-nvim): fix LSP handler error

  • Pull request title has the appropriate conventional commit type and scope where the scope is the name of the pre-existing directory in the project as described above

  • README is properly formatted and uses fenced in links with <url> unless they are inside a [title](url)

  • Entry returns a single plugin spec with the new plugin as the only top level spec (not applicable for recipes or packs).

  • Proper usage of opts table rather than setting things up with the config function.

  • Proper usage of specs table for all specs that are not dependencies of a given plugin (not applicable for recipes or packs).

@Uzaaft
Copy link
Member

Uzaaft commented Apr 16, 2025

Im not convinced this is a good move. Perhaps it should instead be a docs addition?

@ALameLlama ALameLlama force-pushed the feature/add-zsh-to-bash-pack branch from 99f4689 to 0935a26 Compare April 16, 2025 10:13
@ALameLlama
Copy link
Member Author

@Uzaaft I've updated the readme, pretty much every time I edit a file that is zsh, I end up setting the filetype to sh and it does the trick.

I'm all for suggestions on making working with zsh files better

@Uzaaft
Copy link
Member

Uzaaft commented Apr 18, 2025

@Uzaaft I've updated the readme, pretty much every time I edit a file that is zsh, I end up setting the filetype to sh and it does the trick.

I'm all for suggestions on making working with zsh files better

I tried it once, found out that it doesn't work that well due to shellcheck and disabled it 😆

@Uzaaft Uzaaft merged commit f94b701 into AstroNvim:main Apr 25, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants